Commit c8f96df5 authored by Shivasharan S's avatar Shivasharan S Committed by Martin K. Petersen
Browse files

scsi: megaraid_sas: Fix calculation of target ID 



In megasas_get_target_prop(), driver is incorrectly calculating the target
ID for devices with channel 1 and 3.  Due to this, firmware will either
fail the command (if there is no device with the target id sent from
driver) or could return the properties for a target which was not
intended.  Devices could end up with the wrong queue depth due to this.

Fix target id calculation for channel 1 and 3.

Fixes: 96188a89 ("scsi: megaraid_sas: NVME interface target prop added")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarShivasharan S <shivasharan.srikanteshwara@broadcom.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 057959c6

drivers/scsi/megaraid/megaraid_sas_base.c

+2 −1
Original line number Diff line number Diff line
@@ -6558,7 +6558,8 @@ megasas_get_target_prop(struct megasas_instance *instance, 
	int ret;

	struct megasas_cmd *cmd;

	struct megasas_dcmd_frame *dcmd;

	u16 targetId = (sdev->channel % 2) + sdev->id;

	u16 targetId = ((sdev->channel % 2) * MEGASAS_MAX_DEV_PER_CHANNEL) +

			sdev->id;



	cmd = megasas_get_cmd(instance);