Skip to content
Commit ca2a05aa authored by J. Bruce Fields's avatar J. Bruce Fields
Browse files

nfsd: Fix handling of negative lengths in read_buf()



The length "nbytes" passed into read_buf should never be negative, but
we check only for too-large values of "nbytes", not for too-small
values.  Make nbytes unsigned, so it's clear that the former tests are
sufficient.  (Despite this read_buf() currently correctly returns an xdr
error in the case of a negative length, thanks to an unsigned
comparison with size_of() and bounds-checking in kmalloc().  This seems
very fragile, though.)

Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
parent a490c681
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment