Commit cbbb7b31 authored by Martin K. Petersen's avatar Martin K. Petersen Committed by Christoph Hellwig
Browse files

mpt2sas: Rework the MSI-X grouping code 



On systems with a non power-of-two CPU count the existing MSI-X grouping
code failed to distribute interrupts correctly. Rework the code to
handle arbitrary processor counts.

Also remove the hardcoded upper limit on the number of processors so we
can boot on large systems.

Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Acked-by: default avatarSreekanth Reddy <Sreekanth.reddy@avagotech.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 9f21316f

drivers/scsi/mpt2sas/mpt2sas_base.c

+23 −41
Original line number Original line Diff line number Diff line
@@ -1332,53 +1332,35 @@ _base_request_irq(struct MPT2SAS_ADAPTER *ioc, u8 index, u32 vector) 
static void

static void

_base_assign_reply_queues(struct MPT2SAS_ADAPTER *ioc)

_base_assign_reply_queues(struct MPT2SAS_ADAPTER *ioc)

{

{

	struct adapter_reply_queue *reply_q;

	unsigned int cpu, nr_cpus, nr_msix, index = 0;

	int cpu_id;

	int cpu_grouping, loop, grouping, grouping_mod;





	if (!_base_is_controller_msix_enabled(ioc))

	if (!_base_is_controller_msix_enabled(ioc))

		return;

		return;





	memset(ioc->cpu_msix_table, 0, ioc->cpu_msix_table_sz);

	memset(ioc->cpu_msix_table, 0, ioc->cpu_msix_table_sz);

	/* when there are more cpus than available msix vectors,



	 * then group cpus togeather on same irq

	nr_cpus = num_online_cpus();

	 */

	nr_msix = ioc->reply_queue_count = min(ioc->reply_queue_count,

	if (ioc->cpu_count > ioc->msix_vector_count) {

					       ioc->facts.MaxMSIxVectors);

		grouping = ioc->cpu_count / ioc->msix_vector_count;

	if (!nr_msix)

		grouping_mod = ioc->cpu_count % ioc->msix_vector_count;

		return;

		if (grouping < 2 || (grouping == 2 && !grouping_mod))



			cpu_grouping = 2;

	cpu = cpumask_first(cpu_online_mask);

		else if (grouping < 4 || (grouping == 4 && !grouping_mod))



			cpu_grouping = 4;

	do {

		else if (grouping < 8 || (grouping == 8 && !grouping_mod))

		unsigned int i, group = nr_cpus / nr_msix;

			cpu_grouping = 8;



		else

		if (index < nr_cpus % nr_msix)

			cpu_grouping = 16;

			group++;

	} else



		cpu_grouping = 0;

		for (i = 0 ; i < group ; i++) {



			ioc->cpu_msix_table[cpu] = index;

	loop = 0;

			cpu = cpumask_next(cpu, cpu_online_mask);

	reply_q = list_entry(ioc->reply_queue_list.next,

	     struct adapter_reply_queue, list);

	for_each_online_cpu(cpu_id) {

		if (!cpu_grouping) {

			ioc->cpu_msix_table[cpu_id] = reply_q->msix_index;

			reply_q = list_entry(reply_q->list.next,

			    struct adapter_reply_queue, list);

		} else {

			if (loop < cpu_grouping) {

				ioc->cpu_msix_table[cpu_id] =

					reply_q->msix_index;

				loop++;

			} else {

				reply_q = list_entry(reply_q->list.next,

				    struct adapter_reply_queue, list);

				ioc->cpu_msix_table[cpu_id] =

					reply_q->msix_index;

				loop = 1;

			}

		}

		}

		}



		index++;



	} while (cpu < nr_cpus);

}

}





/**

/**