Commit cc002691 authored by Philipp Hortmann's avatar Philipp Hortmann Committed by Greg Kroah-Hartman
Browse files

staging: vt6655: Convert macro MACvDisableProtectMD 



Convert macro MACvDisableProtectMD to static function which calls the
new common static function vt6655_mac_clear_bits. This saves
codelines and multiline macros are not liked by kernel community.
Function name is also changed to avoid CamelCase which is not accepted
by checkpatch.pl and to clean up namespace.

Signed-off-by: default avatarPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/4cb2b8025adde2a3addfd8e954faf18a0a8032aa.1659892670.git.philipp.g.hortmann@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 17ca6537

drivers/staging/vt6655/device_main.c

+15 −1
Original line number Diff line number Diff line
@@ -225,11 +225,25 @@ static void vt6655_mac_set_bits(void __iomem *iobase, u32 mask) 
	iowrite32(reg_value, iobase + MAC_REG_ENCFG);

}



static void vt6655_mac_clear_bits(void __iomem *iobase, u32 mask)

{

	u32 reg_value;



	reg_value = ioread32(iobase + MAC_REG_ENCFG);

	reg_value = reg_value & ~mask;

	iowrite32(reg_value, iobase + MAC_REG_ENCFG);

}



static void vt6655_mac_en_protect_md(void __iomem *iobase)

{

	vt6655_mac_set_bits(iobase, ENCFG_PROTECTMD);

}



static void vt6655_mac_dis_protect_md(void __iomem *iobase)

{

	vt6655_mac_clear_bits(iobase, ENCFG_PROTECTMD);

}



/*

 * Initialisation of MAC & BBP registers

 */
@@ -1477,7 +1491,7 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw, 
		if (conf->use_cts_prot)

			vt6655_mac_en_protect_md(priv->port_offset);

		else

			MACvDisableProtectMD(priv->port_offset);

			vt6655_mac_dis_protect_md(priv->port_offset);

	}



	if (changed & BSS_CHANGED_ERP_SLOT) {

drivers/staging/vt6655/mac.h

+1 −9
Original line number Diff line number Diff line
@@ -12,7 +12,7 @@ 
 * Revision History:

 *      07-01-2003 Bryan YC Fan:  Re-write codes to support VT3253 spec.

 *      08-25-2003 Kyle Hsu:      Porting MAC functions from sim53.

 *      09-03-2003 Bryan YC Fan:  Add MACvDisableProtectMD & vt6655_mac_en_protect_md

 *      09-03-2003 Bryan YC Fan:  Add vt6655_mac_dis_protect_md & vt6655_mac_en_protect_md

 */



#ifndef __MAC_H__
@@ -543,14 +543,6 @@ 
#define MACvSelectPage1(iobase)				\

	iowrite8(1, iobase + MAC_REG_PAGE1SEL)



#define MACvDisableProtectMD(iobase)					\

do {									\

	unsigned long dwOrgValue;					\

	dwOrgValue = ioread32(iobase + MAC_REG_ENCFG);			\

	dwOrgValue = dwOrgValue & ~ENCFG_PROTECTMD;			\

	iowrite32((u32)dwOrgValue, iobase + MAC_REG_ENCFG);		\

} while (0)



#define MACvEnableBarkerPreambleMd(iobase)				\

do {									\

	unsigned long dwOrgValue;					\