Commit cc95b23c authored by Lijun Ou's avatar Lijun Ou Committed by Doug Ledford
Browse files

RDMA/hns: Encapsulate some lines for setting sq size in user mode 



It needs to check the sq size with integrity when configures
the relatived parameters of sq. Here moves the relatived code
into a special function.

Signed-off-by: default avatarLijun Ou <oulijun@huawei.com>
Link: https://lore.kernel.org/r/1565276034-97329-2-git-send-email-oulijun@huawei.com


Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent a3e2d4c7

drivers/infiniband/hw/hns/hns_roce_qp.c

+22 −7
Original line number Diff line number Diff line
@@ -324,16 +324,12 @@ static int hns_roce_set_rq_size(struct hns_roce_dev *hr_dev, 
	return 0;

}



static int hns_roce_set_user_sq_size(struct hns_roce_dev *hr_dev,

static int check_sq_size_with_integrity(struct hns_roce_dev *hr_dev,

					struct ib_qp_cap *cap,

				     struct hns_roce_qp *hr_qp,

					struct hns_roce_ib_create_qp *ucmd)

{

	u32 roundup_sq_stride = roundup_pow_of_two(hr_dev->caps.max_sq_desc_sz);

	u8 max_sq_stride = ilog2(roundup_sq_stride);

	u32 ex_sge_num;

	u32 page_size;

	u32 max_cnt;



	/* Sanity check SQ size before proceeding */

	if ((u32)(1 << ucmd->log_sq_bb_count) > hr_dev->caps.max_wqes ||
@@ -349,6 +345,25 @@ static int hns_roce_set_user_sq_size(struct hns_roce_dev *hr_dev, 
		return -EINVAL;

	}



	return 0;

}



static int hns_roce_set_user_sq_size(struct hns_roce_dev *hr_dev,

				     struct ib_qp_cap *cap,

				     struct hns_roce_qp *hr_qp,

				     struct hns_roce_ib_create_qp *ucmd)

{

	u32 ex_sge_num;

	u32 page_size;

	u32 max_cnt;

	int ret;



	ret = check_sq_size_with_integrity(hr_dev, cap, ucmd);

	if (ret) {

		ibdev_err(&hr_dev->ib_dev, "Sanity check sq size failed\n");

		return ret;

	}



	hr_qp->sq.wqe_cnt = 1 << ucmd->log_sq_bb_count;

	hr_qp->sq.wqe_shift = ucmd->log_sq_stride;