Commit ccba4e5b authored by Wenjing Liu's avatar Wenjing Liu Committed by Alex Deucher
Browse files

drm/amd/display: add more link_hwss types and method to decide which one 



[why]
as we add more link_hwss we are making a generic way to determine which type
of link_hwss we should use.
Later on we may think of introduce a link policy layer. it could be a thin layer
that decide the type of link_hwss we use. So instead of passing in link and link_res
we can just pass in link_policy and swtich based on link_policy->get_link_hwss_type.

Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Reviewed-by: default avatarAric Cyr <Aric.Cyr@amd.com>
Acked-by: default avatarRodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: default avatarWenjing Liu <wenjing.liu@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 5279e091

drivers/gpu/drm/amd/display/dc/core/dc_link_hwss.c

+47 −6
Original line number Original line Diff line number Diff line
@@ -844,7 +844,16 @@ void setup_dp_hpo_stream(struct pipe_ctx *pipe_ctx, bool enable) 
	}

	}

}

}





/******************************* dio_link_hwss ********************************/

static void set_dummy_throttled_vcp_size(struct pipe_ctx *pipe_ctx,

		struct fixed31_32 throttled_vcp_size);



/************************* below goes to dio_link_hwss ************************/

static bool can_use_dio_link_hwss(const struct dc_link *link,

		const struct link_resource *link_res)

{

	return link->link_enc != NULL;

}



static void set_dio_throttled_vcp_size(struct pipe_ctx *pipe_ctx,

static void set_dio_throttled_vcp_size(struct pipe_ctx *pipe_ctx,

		struct fixed31_32 throttled_vcp_size)

		struct fixed31_32 throttled_vcp_size)

{

{
@@ -855,7 +864,17 @@ static void set_dio_throttled_vcp_size(struct pipe_ctx *pipe_ctx, 
				throttled_vcp_size);

				throttled_vcp_size);

}

}





/***************************** hpo_dp_link_hwss *******************************/

static const struct dc_link_hwss dio_link_hwss = {

	.set_throttled_vcp_size = set_dio_throttled_vcp_size,

};



/*********************** below goes to hpo_dp_link_hwss ***********************/

static bool can_use_dp_hpo_link_hwss(const struct dc_link *link,

		const struct link_resource *link_res)

{

	return link_res->hpo_dp_link_enc != NULL;

}



static void set_dp_hpo_throttled_vcp_size(struct pipe_ctx *pipe_ctx,

static void set_dp_hpo_throttled_vcp_size(struct pipe_ctx *pipe_ctx,

		struct fixed31_32 throttled_vcp_size)

		struct fixed31_32 throttled_vcp_size)

{

{
@@ -898,15 +917,33 @@ static const struct dc_link_hwss hpo_dp_link_hwss = { 
	 */

	 */

	.set_hblank_min_symbol_width = set_dp_hpo_hblank_min_symbol_width,

	.set_hblank_min_symbol_width = set_dp_hpo_hblank_min_symbol_width,

};

};

/*********************** below goes to dpia_link_hwss *************************/

static bool can_use_dpia_link_hwss(const struct dc_link *link,

		const struct link_resource *link_res)

{

	return link->is_dig_mapping_flexible &&

			link->dc->res_pool->funcs->link_encs_assign;

}





static const struct dc_link_hwss dio_link_hwss = {

static const struct dc_link_hwss dpia_link_hwss = {

	.set_throttled_vcp_size = set_dio_throttled_vcp_size,

	.set_throttled_vcp_size = set_dummy_throttled_vcp_size,

};



/*********************** below goes to link_hwss ******************************/

static void set_dummy_throttled_vcp_size(struct pipe_ctx *pipe_ctx,

		struct fixed31_32 throttled_vcp_size)

{

	return;

}



static const struct dc_link_hwss dummy_link_hwss = {

	.set_throttled_vcp_size = set_dummy_throttled_vcp_size,

};

};





const struct dc_link_hwss *dc_link_hwss_get(const struct dc_link *link,

const struct dc_link_hwss *dc_link_hwss_get(const struct dc_link *link,

		const struct link_resource *link_res)

		const struct link_resource *link_res)

{

{

	if (link_res->hpo_dp_link_enc)

	if (can_use_dp_hpo_link_hwss(link, link_res))

		/* TODO: some assumes that if decided link settings is 128b/132b

		/* TODO: some assumes that if decided link settings is 128b/132b

		 * channel coding format hpo_dp_link_enc should be used.

		 * channel coding format hpo_dp_link_enc should be used.

		 * Others believe that if hpo_dp_link_enc is available in link

		 * Others believe that if hpo_dp_link_enc is available in link
@@ -925,8 +962,12 @@ const struct dc_link_hwss *dc_link_hwss_get(const struct dc_link *link, 
		 * do work for all functions

		 * do work for all functions

		 */

		 */

		return &hpo_dp_link_hwss;

		return &hpo_dp_link_hwss;

	else

	else if (can_use_dpia_link_hwss(link, link_res))

		return &dpia_link_hwss;

	else if (can_use_dio_link_hwss(link, link_res))

		return &dio_link_hwss;

		return &dio_link_hwss;

	else

		return &dummy_link_hwss;

}

}





#undef DC_LOGGER
 
#undef DC_LOGGER

drivers/gpu/drm/amd/display/dc/inc/link_hwss.h

+3 −0
Original line number Original line Diff line number Diff line
@@ -78,6 +78,9 @@ struct fixed31_32; 
struct pipe_ctx;

struct pipe_ctx;





struct dc_link_hwss {

struct dc_link_hwss {

	/* you must define a dummy implementation and assign the function to

	 * dummy_link_hwss if you don't want to check for NULL pointer

	 */

	void (*set_throttled_vcp_size)(struct pipe_ctx *pipe_ctx,

	void (*set_throttled_vcp_size)(struct pipe_ctx *pipe_ctx,

			struct fixed31_32 throttled_vcp_size);

			struct fixed31_32 throttled_vcp_size);