Commit ccea44fa authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

driver core: remove device_create() 



There are no more users of this, and it is racy.  Use
device_create_drvdata() or device_create_vargs() instead.

Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 3bfd49c8

drivers/base/core.c

+0 −34
Original line number Diff line number Diff line
@@ -1273,40 +1273,6 @@ struct device *device_create_drvdata(struct class *class, 
}

EXPORT_SYMBOL_GPL(device_create_drvdata);



/**

 * device_create - creates a device and registers it with sysfs

 * @class: pointer to the struct class that this device should be registered to

 * @parent: pointer to the parent struct device of this new device, if any

 * @devt: the dev_t for the char device to be added

 * @fmt: string for the device's name

 *

 * This function can be used by char device classes.  A struct device

 * will be created in sysfs, registered to the specified class.

 *

 * A "dev" file will be created, showing the dev_t for the device, if

 * the dev_t is not 0,0.

 * If a pointer to a parent struct device is passed in, the newly created

 * struct device will be a child of that device in sysfs.

 * The pointer to the struct device will be returned from the call.

 * Any further sysfs files that might be required can be created using this

 * pointer.

 *

 * Note: the struct class passed to this function must have previously

 * been created with a call to class_create().

 */

struct device *device_create(struct class *class, struct device *parent,

			     dev_t devt, const char *fmt, ...)

{

	va_list vargs;

	struct device *dev;



	va_start(vargs, fmt);

	dev = device_create_vargs(class, parent, devt, NULL, fmt, vargs);

	va_end(vargs);

	return dev;

}

EXPORT_SYMBOL_GPL(device_create);



static int __match_devt(struct device *dev, void *data)

{

	dev_t *devt = data;

include/linux/device.h

+0 −3
Original line number Diff line number Diff line
@@ -470,9 +470,6 @@ extern struct device *device_create_vargs(struct class *cls, 
					  void *drvdata,

					  const char *fmt,

					  va_list vargs);

extern struct device *device_create(struct class *cls, struct device *parent,

				    dev_t devt, const char *fmt, ...)

				    __attribute__((format(printf, 4, 5)));

extern struct device *device_create_drvdata(struct class *cls,

					    struct device *parent,

					    dev_t devt,