Skip to content
Commit cd0ea241 authored by Jarek Poplawski's avatar Jarek Poplawski Committed by David S. Miller
Browse files

gianfar: Fix crashes on RX path (Was Re: [Bugme-new] [Bug 19692] New:...


gianfar: Fix crashes on RX path (Was Re: [Bugme-new] [Bug 19692] New: linux-2.6.36-rc5 crash with gianfar ethernet at full line rate traffic)

The rx_recycle queue is global per device but can be accesed by many
napi handlers at the same time, so it needs full skb_queue primitives
(with locking). Otherwise, various crashes caused by broken skbs are
possible.

This patch resolves, at least partly, bugzilla bug 19692. (Because of
some doubts that there could be still something around which is hard
to reproduce my proposal is to leave this bug opened for a month.)

Fixes commit: 0fd56bb5 ("gianfar: Add
support for skb recycling")

Reported-by: default avataremin ak <eminak71@gmail.com>
Tested-by: default avataremin ak <eminak71@gmail.com>
Signed-off-by: default avatarJarek Poplawski <jarkao2@gmail.com>
CC: Andy Fleming <afleming@freescale.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7a876b0e
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment