Commit cd9df0c2 authored by René Rebe's avatar René Rebe Committed by Martin K. Petersen
Browse files

scsi: qla1280: Fix printk regression 

Since Linus Torvalds reinstated KERN_CONT in commit 4bcc595c ("printk:
reinstate KERN_CONT for printing continuation lines") in 2015, the qla1280
SCSI driver printed a rather ugly and screen real estate wasting multi-line
per device status glibberish during boot. Fix this by adding KERN_CONT as
needed.

Tested on my Sgi Octane: https://youtu.be/Lfqe1SYR2jk

Link: https://lore.kernel.org/r/20201210.223944.388095546873159172.rene@exactcode.com


Signed-off-by: default avatarRené Rebe <rene@exactcode.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d3ba622d

drivers/scsi/qla1280.c

+6 −6
Original line number Diff line number Diff line
@@ -3906,18 +3906,18 @@ qla1280_get_target_parameters(struct scsi_qla_host *ha, 
	printk(KERN_INFO "scsi(%li:%d:%d:%d):", ha->host_no, bus, target, lun);



	if (mb[3] != 0) {

		printk(" Sync: period %d, offset %d",

		printk(KERN_CONT " Sync: period %d, offset %d",

		       (mb[3] & 0xff), (mb[3] >> 8));

		if (mb[2] & BIT_13)

			printk(", Wide");

			printk(KERN_CONT ", Wide");

		if ((mb[2] & BIT_5) && ((mb[6] >> 8) & 0xff) >= 2)

			printk(", DT");

			printk(KERN_CONT ", DT");

	} else

		printk(" Async");

		printk(KERN_CONT " Async");



	if (device->simple_tags)

		printk(", Tagged queuing: depth %d", device->queue_depth);

	printk("\n");

		printk(KERN_CONT ", Tagged queuing: depth %d", device->queue_depth);

	printk(KERN_CONT "\n");

}