Commit ce1edddd authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: ni_at_ao: cleanup dev->board_name usage 



This legacy driver does no additional probing so the dev->board_name
will already be properly initialized by the comedi core before calling
the (*attach) function.

Remove the unnecessary initialization of dev->board_name and use it
when requesting the resources instead of the open-coded strings.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3cbc2810

drivers/staging/comedi/drivers/ni_at_ao.c

+1 −3
Original line number Diff line number Diff line
@@ -348,14 +348,12 @@ static int atao_attach(struct comedi_device *dev, struct comedi_devconfig *it) 


	printk(KERN_INFO "comedi%d: ni_at_ao: 0x%04lx", dev->minor, iobase);



	if (!request_region(iobase, ATAO_SIZE, "ni_at_ao")) {

	if (!request_region(iobase, ATAO_SIZE, dev->board_name)) {

		printk(" I/O port conflict\n");

		return -EIO;

	}

	dev->iobase = iobase;



	dev->board_name = board->name;



	devpriv = kzalloc(sizeof(*devpriv), GFP_KERNEL);

	if (!devpriv)

		return -ENOMEM;