Commit cfb12180 authored by Jaehee Park's avatar Jaehee Park Committed by Greg Kroah-Hartman
Browse files

staging: greybus: remove empty callback function 



Remove the optional remove callback for the soc_codec_dev_gbaudio
structure. The only place it is referenced is
snd_soc_component_remove() which is only called if the sound_component
pointer is non-null. The null function pointers here can be optionally
ommitted. When a sound component is registered this way, the remove
callback is optional. We can safely remove the whole gbcodec_remove
function, which used to be an empty function with a void return type.

Suggested-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarJaehee Park <jhpark1013@gmail.com>
Link: https://lore.kernel.org/r/12037ae2502ad7d0311bcdf2178c3d2156293236.1649824370.git.jhpark1013@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5a9bdd6f

drivers/staging/greybus/audio_codec.c

+0 −8
Original line number Diff line number Diff line
@@ -1029,12 +1029,6 @@ static int gbcodec_probe(struct snd_soc_component *comp) 
	return 0;

}



static void gbcodec_remove(struct snd_soc_component *comp)

{

	/* Empty function for now */

	return;

}



static int gbcodec_write(struct snd_soc_component *comp, unsigned int reg,

			 unsigned int value)

{
@@ -1049,8 +1043,6 @@ static unsigned int gbcodec_read(struct snd_soc_component *comp, 


static const struct snd_soc_component_driver soc_codec_dev_gbaudio = {

	.probe	= gbcodec_probe,

	.remove	= gbcodec_remove,



	.read = gbcodec_read,

	.write = gbcodec_write,

};