Commit d15a65be authored by Tim Sell's avatar Tim Sell Committed by Greg Kroah-Hartman
Browse files

staging: unisys: prevent faults processing messages 



Prevent faults processing messages for devices that no driver has yet
registered to handle.

Previously, code of the form:

    drv = to_visor_driver(dev->device.driver);
    if (!drv)
        goto away;

was not having the desired intent, because to_visor_driver() was
essentially returning garbage if its argument was NULL.  The only existing
case of this is in initiate_chipset_device_pause_resume(), which is called
during IOVM service partition recovery.  We were thus faulting when IOVM
service partition recovery was initiated on a bus that had at least one
device for which no function driver had registered
(visorbus_register_visor_driver).

Signed-off-by: default avatarTim Sell <Timothy.Sell@unisys.com>
Signed-off-by: default avatarBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent addce19f

drivers/staging/unisys/include/visorbus.h

+2 −1
Original line number Diff line number Diff line
@@ -113,7 +113,8 @@ struct visor_driver { 
	struct driver_attribute version_attr;

};



#define to_visor_driver(x) container_of(x, struct visor_driver, driver)

#define to_visor_driver(x) ((x) ? \

	(container_of(x, struct visor_driver, driver)) : (NULL))



/** A device type for things "plugged" into the visorbus bus */