Commit d248b277 authored by Meng Tang's avatar Meng Tang Committed by Takashi Iwai
Browse files

sound: core: remove initialise static variables to 0 



Initializing the static variable to 0 causes the following error
when exec checkpatch:

ERROR: do not initialise statics to 0
FILE: sound/sound_core.c:142:
static int preclaim_oss = 0;

In addition, considering the following way of writing
139: #ifdef config_sound_oss_core_preclaim
140: Static int preclaim_oss = 1;
141: #ELSE
142: Static int preclaim_oss = 0;
143: #ENDIF
We can optimize it by IS_ENABLED(CONFIG_SOUND_OSS_CORE_PRECLAIM),
so modified it to
static int preclaim_oss = IS_ENABLED(CONFIG_SOUND_OSS_CORE_PRECLAIM);

Signed-off-by: default avatarMeng Tang <tangmeng@uniontech.com>
Link: https://lore.kernel.org/r/20220228050253.1649-1-tangmeng@uniontech.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent ca1697eb

sound/sound_core.c

+1 −5
Original line number Diff line number Diff line
@@ -136,11 +136,7 @@ struct sound_unit 
 * All these clutters are scheduled to be removed along with

 * sound-slot/service-* module aliases.

 */

#ifdef CONFIG_SOUND_OSS_CORE_PRECLAIM

static int preclaim_oss = 1;

#else

static int preclaim_oss = 0;

#endif

static int preclaim_oss = IS_ENABLED(CONFIG_SOUND_OSS_CORE_PRECLAIM);



module_param(preclaim_oss, int, 0444);