Commit d2b47721 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

staging: greybus: audio: replace safe list iteration 



No entry is being removed from the list when iterating the widget list
in gbaudio_dapm_free_controls() so there's no need to use
list_for_each_entry_safe().

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20220610075347.18917-1-johan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 991ebc73

drivers/staging/greybus/audio_helper.c

+2 −3
Original line number Diff line number Diff line
@@ -115,7 +115,7 @@ int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm, 
			       int num)

{

	int i;

	struct snd_soc_dapm_widget *w, *next_w, *tmp_w;

	struct snd_soc_dapm_widget *w, *tmp_w;

#ifdef CONFIG_DEBUG_FS

	struct dentry *parent = dapm->debugfs_dapm;

	struct dentry *debugfs_w = NULL;
@@ -125,8 +125,7 @@ int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm, 
	for (i = 0; i < num; i++) {

		/* below logic can be optimized to identify widget pointer */

		w = NULL;

		list_for_each_entry_safe(tmp_w, next_w, &dapm->card->widgets,

					 list) {

		list_for_each_entry(tmp_w, &dapm->card->widgets, list) {

			if (tmp_w->dapm == dapm &&

			    !strcmp(tmp_w->name, widget->name)) {

				w = tmp_w;