Unverified Commit d40ab86f authored by Amadeusz Sławiński's avatar Amadeusz Sławiński Committed by Mark Brown
Browse files

ASoC: topology: Ensure that needed parameters are set 



As snd_soc_tplg_component_load is exported function, which means it is
part of API, there should be checks if it is called with proper
parameters.

Signed-off-by: default avatarAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/20210114163602.911205-2-amadeuszx.slawinski@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 879a67e3

sound/soc/soc-topology.c

+8 −2
Original line number Diff line number Diff line
@@ -2659,8 +2659,14 @@ int snd_soc_tplg_component_load(struct snd_soc_component *comp, 
	struct soc_tplg tplg;

	int ret;



	/* component needs to exist to keep and reference data while parsing */

	if (!comp)

	/*

	 * check if we have sane parameters:

	 * comp - needs to exist to keep and reference data while parsing

	 * comp->dev - used for resource management and prints

	 * comp->card - used for setting card related parameters

	 * fw - we need it, as it is the very thing we parse

	 */

	if (!comp || !comp->dev || !comp->card || !fw)

		return -EINVAL;



	/* setup parsing context */