Commit d515d0ff authored by Haiyang Zhang's avatar Haiyang Zhang Committed by Greg Kroah-Hartman
Browse files

staging: hv: remove the carrier status check from netvsc_open() 



Checking carrier status in netvsc_open() is not necessary.

Signed-off-by: default avatarHaiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 657d1b0d

drivers/staging/hv/TODO

+0 −2
Original line number Diff line number Diff line 
TODO:

	- audit the network driver

	  - checking for carrier inside open is wrong, network device API

            confusion??

	- audit the scsi driver



Please send patches for this code to Greg Kroah-Hartman <gregkh@suse.de>,

drivers/staging/hv/netvsc_drv.c

+7 −12
Original line number Diff line number Diff line
@@ -69,19 +69,14 @@ static int netvsc_open(struct net_device *net) 
	struct hv_device *device_obj = net_device_ctx->device_ctx;

	int ret = 0;



	if (netif_carrier_ok(net)) {

	/* Open up the device */

	ret = rndis_filter_open(device_obj);

	if (ret != 0) {

			netdev_err(net, "unable to open device (ret %d).\n",

				   ret);

		netdev_err(net, "unable to open device (ret %d).\n", ret);

		return ret;

	}



	netif_start_queue(net);

	} else {

		netdev_err(net, "unable to open device...link is down.\n");

	}



	return ret;

}