Commit d5e5f6d3 authored by Fabio Aiuto's avatar Fabio Aiuto Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723bs: move function prototypes out of os_dep/int_fs.c 



fix the following checkpatch issues:

WARNING: externs should be avoided in .c files
196: FILE: drivers/staging/rtl8723bs/os_dep/os_intfs.c:196:
+int _netdev_open(struct net_device *pnetdev);
--
WARNING: externs should be avoided in .c files
197: FILE: drivers/staging/rtl8723bs/os_dep/os_intfs.c:197:
+int netdev_open(struct net_device *pnetdev);

moved function prototype in include/osdep_intf.h
removed function prototype and made a static
removed unnecessary extern declaration in os_dep/ioctl_cfg80211.c

Signed-off-by: default avatarFabio Aiuto <fabioaiuto83@gmail.com>
Link: https://lore.kernel.org/r/4604b856b9c20f1141e19894f46934cb860eebd4.1616503354.git.fabioaiuto83@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f6df723d

drivers/staging/rtl8723bs/include/osdep_intf.h

+2 −0
Original line number Diff line number Diff line
@@ -69,4 +69,6 @@ void rtw_ndev_destructor(struct net_device *ndev); 
int rtw_suspend_common(struct adapter *padapter);

int rtw_resume_common(struct adapter *padapter);



int netdev_open(struct net_device *pnetdev);



#endif	/* _OSDEP_INTF_H_ */

drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c

+0 −2
Original line number Diff line number Diff line
@@ -1259,8 +1259,6 @@ static int cfg80211_rtw_get_station(struct wiphy *wiphy, 
	return ret;

}



extern int netdev_open(struct net_device *pnetdev);



static int cfg80211_rtw_change_iface(struct wiphy *wiphy,

				     struct net_device *ndev,

				     enum nl80211_iftype type,

drivers/staging/rtl8723bs/os_dep/os_intfs.c

+1 −3
Original line number Diff line number Diff line
@@ -193,8 +193,6 @@ MODULE_PARM_DESC(rtw_tx_pwr_lmt_enable, "0:Disable, 1:Enable, 2: Depend on efuse 
module_param(rtw_tx_pwr_by_rate, int, 0644);

MODULE_PARM_DESC(rtw_tx_pwr_by_rate, "0:Disable, 1:Enable, 2: Depend on efuse");



int _netdev_open(struct net_device *pnetdev);

int netdev_open(struct net_device *pnetdev);

static int netdev_close(struct net_device *pnetdev);



static void loadparam(struct adapter *padapter, struct net_device *pnetdev)
@@ -875,7 +873,7 @@ int rtw_drv_register_netdev(struct adapter *if1) 
	return _rtw_drv_register_netdev(padapter, name);

}



int _netdev_open(struct net_device *pnetdev)

static int _netdev_open(struct net_device *pnetdev)

{

	uint status;

	struct adapter *padapter = rtw_netdev_priv(pnetdev);