Commit d601ad56 authored by Phillip Potter's avatar Phillip Potter Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: convert/remove DBG_88E calls in os_dep/usb_ops_linux.c 



Convert DBG_88E macro calls in os_dep/usb_ops_linux.c to use netdev_dbg
when they may display useful information, and remove erroneous DBG_88E
calls entirely.

Signed-off-by: default avatarPhillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20220108005550.26264-6-phil@philpotter.co.uk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 198fae42

drivers/staging/r8188eu/os_dep/usb_ops_linux.c

+11 −13
Original line number Diff line number Diff line
@@ -32,8 +32,6 @@ void rtw_read_port_cancel(struct adapter *padapter) 
	int i;

	struct recv_buf *precvbuf = (struct recv_buf *)padapter->recvpriv.precv_buf;



	DBG_88E("%s\n", __func__);



	padapter->bReadPortCancel = true;



	for (i = 0; i < NR_RECVBUFF; i++) {
@@ -72,30 +70,32 @@ static void usb_write_port_complete(struct urb *purb, struct pt_regs *regs) 


	if (padapter->bSurpriseRemoved || padapter->bDriverStopped ||

	    padapter->bWritePortCancel) {

		DBG_88E("%s(): TX Warning! bDriverStopped(%d) OR bSurpriseRemoved(%d) bWritePortCancel(%d) pxmitbuf->ext_tag(%x)\n",

			__func__, padapter->bDriverStopped,

			padapter->bSurpriseRemoved, padapter->bReadPortCancel,

			pxmitbuf->ext_tag);

		netdev_dbg(padapter->pnetdev,

			   "TX Warning! bDriverStopped(%d) OR bSurpriseRemoved(%d)\n",

			   padapter->bDriverStopped, padapter->bSurpriseRemoved);

		netdev_dbg(padapter->pnetdev,

			   "TX Warning! bWritePortCancel(%d) pxmitbuf->ext_tag(%x)\n",

			   padapter->bReadPortCancel, pxmitbuf->ext_tag);



		goto check_completion;

	}



	if (purb->status) {

		DBG_88E("###=> urb_write_port_complete status(%d)\n", purb->status);

		netdev_dbg(padapter->pnetdev, "status(%d)\n", purb->status);

		if (purb->status == -EINPROGRESS) {

			goto check_completion;

		} else if (purb->status == -ENOENT) {

			DBG_88E("%s: -ENOENT\n", __func__);

			netdev_dbg(padapter->pnetdev, "-ENOENT\n");

			goto check_completion;

		} else if (purb->status == -ECONNRESET) {

			DBG_88E("%s: -ECONNRESET\n", __func__);

			netdev_dbg(padapter->pnetdev, "-ECONNRESET\n");

			goto check_completion;

		} else if (purb->status == -ESHUTDOWN) {

			padapter->bDriverStopped = true;

			goto check_completion;

		} else if ((purb->status != -EPIPE) && (purb->status != -EPROTO)) {

			padapter->bSurpriseRemoved = true;

			DBG_88E("bSurpriseRemoved = true\n");

			netdev_dbg(padapter->pnetdev, "bSurpriseRemoved = true\n");



			goto check_completion;

		}
@@ -174,7 +174,7 @@ u32 rtw_write_port(struct adapter *padapter, u32 addr, u32 cnt, u8 *wmem) 
	status = usb_submit_urb(purb, GFP_ATOMIC);

	if (status) {

		rtw_sctx_done_err(&pxmitbuf->sctx, RTW_SCTX_DONE_WRITE_PORT_ERR);

		DBG_88E("usb_write_port, status =%d\n", status);

		netdev_dbg(padapter->pnetdev, "usb_write_port, status = %d\n", status);



		switch (status) {

		case -ENODEV:
@@ -202,8 +202,6 @@ void rtw_write_port_cancel(struct adapter *padapter) 
	int i, j;

	struct xmit_buf *pxmitbuf = (struct xmit_buf *)padapter->xmitpriv.pxmitbuf;



	DBG_88E("%s\n", __func__);



	padapter->bWritePortCancel = true;



	for (i = 0; i < NR_XMITBUFF; i++) {