Commit d61b1b36 authored by Phillip Potter's avatar Phillip Potter Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: remove rtw_hal_xmitframe_enqueue function 



Remove rtw_hal_xmitframe_enqueue from hal/hal_intf.c and its one
caller from core/rtw_recv.c, and remove its declaration from
include/hal_intf.h as well. This is just a wrapper function that calls
the function pointer hal_xmitframe_enqueue in struct hal_ops if it
is set, which it never is.

Signed-off-by: default avatarPhillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210906010106.898-10-phil@philpotter.co.uk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6ab0878e

drivers/staging/r8188eu/core/rtw_recv.c

+0 −2
Original line number Original line Diff line number Diff line
@@ -966,8 +966,6 @@ static int validate_recv_ctrl_frame(struct adapter *padapter, 




				pxmitframe->attrib.triggered = 1;

				pxmitframe->attrib.triggered = 1;





				rtw_hal_xmitframe_enqueue(padapter, pxmitframe);



				if (psta->sleepq_len == 0) {

				if (psta->sleepq_len == 0) {

					pstapriv->tim_bitmap &= ~BIT(psta->aid);

					pstapriv->tim_bitmap &= ~BIT(psta->aid);

drivers/staging/r8188eu/hal/hal_intf.c

+0 −8
Original line number Original line Diff line number Diff line
@@ -144,14 +144,6 @@ u8 rtw_hal_intf_ps_func(struct adapter *adapt, 
	return _FAIL;

	return _FAIL;

}

}





s32 rtw_hal_xmitframe_enqueue(struct adapter *padapter,

			      struct xmit_frame *pxmitframe)

{

	if (padapter->HalFunc.hal_xmitframe_enqueue)

		return padapter->HalFunc.hal_xmitframe_enqueue(padapter, pxmitframe);

	return false;

}



s32 rtw_hal_xmit(struct adapter *adapt, struct xmit_frame *pxmitframe)

s32 rtw_hal_xmit(struct adapter *adapt, struct xmit_frame *pxmitframe)

{

{

	if (adapt->HalFunc.hal_xmit)

	if (adapt->HalFunc.hal_xmit)

drivers/staging/r8188eu/include/hal_intf.h

+0 −2
Original line number Original line Diff line number Diff line
@@ -285,8 +285,6 @@ u32 rtw_hal_inirp_deinit(struct adapter *padapter); 




u8	rtw_hal_intf_ps_func(struct adapter *padapter,

u8	rtw_hal_intf_ps_func(struct adapter *padapter,

			     enum hal_intf_ps_func efunc_id, u8 *val);

			     enum hal_intf_ps_func efunc_id, u8 *val);

s32 rtw_hal_xmitframe_enqueue(struct adapter *padapter,

			      struct xmit_frame *pxmitframe);





s32	rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe);

s32	rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe);

s32	rtw_hal_mgnt_xmit(struct adapter *padapter,

s32	rtw_hal_mgnt_xmit(struct adapter *padapter,