Unverified Commit d66149dc authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: SOF: Intel: hda-stream: use SOF helpers for consistency 



Not sure why we mixed sof and hdac helpers, this makes the code way
less readable.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20221024165310.246183-13-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent be4156a2

sound/soc/sof/intel/hda-stream.c

+3 −2
Original line number Original line Diff line number Diff line
@@ -697,7 +697,8 @@ bool hda_dsp_check_stream_irq(struct snd_sof_dev *sdev) 
	/* The function can be called at irq thread, so use spin_lock_irq */

	/* The function can be called at irq thread, so use spin_lock_irq */

	spin_lock_irq(&bus->reg_lock);

	spin_lock_irq(&bus->reg_lock);





	status = snd_hdac_chip_readl(bus, INTSTS);

	status = snd_sof_dsp_read(sdev, HDA_DSP_HDA_BAR, SOF_HDA_INTSTS);



	trace_sof_intel_hda_dsp_check_stream_irq(sdev, status);

	trace_sof_intel_hda_dsp_check_stream_irq(sdev, status);





	/* if Register inaccessible, ignore it.*/

	/* if Register inaccessible, ignore it.*/
@@ -778,7 +779,7 @@ irqreturn_t hda_dsp_stream_threaded_handler(int irq, void *context) 
	for (i = 0, active = true; i < 10 && active; i++) {

	for (i = 0, active = true; i < 10 && active; i++) {

		spin_lock_irq(&bus->reg_lock);

		spin_lock_irq(&bus->reg_lock);





		status = snd_hdac_chip_readl(bus, INTSTS);

		status = snd_sof_dsp_read(sdev, HDA_DSP_HDA_BAR, SOF_HDA_INTSTS);





		/* check streams */

		/* check streams */

		active = hda_dsp_stream_check(bus, status);

		active = hda_dsp_stream_check(bus, status);