Commit d6f712f5 authored by Yinhao Hu's avatar Yinhao Hu Committed by Greg Kroah-Hartman
Browse files

usb: chipidea: fix missing goto in `ci_hdrc_probe` 



From the comment of ci_usb_phy_init, it returns an error code if
usb_phy_init has failed, and it should do some clean up, not just
return directly.

Fix this by goto the error handling.

Fixes: 74475ede ("usb: chipidea: move PHY operation to core")
Reviewed-by: default avatarDongliang Mu <dzm91@hust.edu.cn>
Acked-by: default avatarPeter Chen <peter.chen@kernel.org>
Signed-off-by: default avatarYinhao Hu <dddddd@hust.edu.cn>
Link: https://lore.kernel.org/r/20230412055852.971991-1-dddddd@hust.edu.cn


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a3afbf5c

drivers/usb/chipidea/core.c

+1 −1
Original line number Diff line number Diff line
@@ -1108,7 +1108,7 @@ static int ci_hdrc_probe(struct platform_device *pdev) 
	ret = ci_usb_phy_init(ci);

	if (ret) {

		dev_err(dev, "unable to init phy: %d\n", ret);

		return ret;

		goto ulpi_exit;

	}



	ci->hw_bank.phys = res->start;