Commit d77c4502 authored by Tom Rix's avatar Tom Rix Committed by Vinod Koul
Browse files

dmaengine: dw-edma: remove unused readq_ch and writeq_ch functions 



clang with W=1 reports
drivers/dma/dw-edma/dw-edma-v0-core.c:162:20: error:
  unused function 'writeq_ch' [-Werror,-Wunused-function]
static inline void writeq_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch,
                   ^
drivers/dma/dw-edma/dw-edma-v0-core.c:185:19: error:
  unused function 'readq_ch' [-Werror,-Wunused-function]
static inline u64 readq_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch,
                  ^
These functions and their wrapping macros are not used, so remove them.

Signed-off-by: default avatarTom Rix <trix@redhat.com>
Link: https://lore.kernel.org/r/20230320234906.1730308-1-trix@redhat.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 3366c6fe

drivers/dma/dw-edma/dw-edma-v0-core.c

+0 −56
Original line number Original line Diff line number Diff line
@@ -159,62 +159,6 @@ static inline u32 readl_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch, 
#define GET_CH_32(dw, dir, ch, name) \

#define GET_CH_32(dw, dir, ch, name) \

	readl_ch(dw, dir, ch, &(__dw_ch_regs(dw, dir, ch)->name))

	readl_ch(dw, dir, ch, &(__dw_ch_regs(dw, dir, ch)->name))





static inline void writeq_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch,

			     u64 value, void __iomem *addr)

{

	if (dw->chip->mf == EDMA_MF_EDMA_LEGACY) {

		u32 viewport_sel;

		unsigned long flags;



		raw_spin_lock_irqsave(&dw->lock, flags);



		viewport_sel = FIELD_PREP(EDMA_V0_VIEWPORT_MASK, ch);

		if (dir == EDMA_DIR_READ)

			viewport_sel |= BIT(31);



		writel(viewport_sel,

		       &(__dw_regs(dw)->type.legacy.viewport_sel));

		writeq(value, addr);



		raw_spin_unlock_irqrestore(&dw->lock, flags);

	} else {

		writeq(value, addr);

	}

}



static inline u64 readq_ch(struct dw_edma *dw, enum dw_edma_dir dir, u16 ch,

			   const void __iomem *addr)

{

	u64 value;



	if (dw->chip->mf == EDMA_MF_EDMA_LEGACY) {

		u32 viewport_sel;

		unsigned long flags;



		raw_spin_lock_irqsave(&dw->lock, flags);



		viewport_sel = FIELD_PREP(EDMA_V0_VIEWPORT_MASK, ch);

		if (dir == EDMA_DIR_READ)

			viewport_sel |= BIT(31);



		writel(viewport_sel,

		       &(__dw_regs(dw)->type.legacy.viewport_sel));

		value = readq(addr);



		raw_spin_unlock_irqrestore(&dw->lock, flags);

	} else {

		value = readq(addr);

	}



	return value;

}



#define SET_CH_64(dw, dir, ch, name, value) \

	writeq_ch(dw, dir, ch, value, &(__dw_ch_regs(dw, dir, ch)->name))



#define GET_CH_64(dw, dir, ch, name) \

	readq_ch(dw, dir, ch, &(__dw_ch_regs(dw, dir, ch)->name))



/* eDMA management callbacks */

/* eDMA management callbacks */

void dw_edma_v0_core_off(struct dw_edma *dw)

void dw_edma_v0_core_off(struct dw_edma *dw)

{

{