Commit d8236854 authored Mar 15, 2023 by Wei Chen Committed by Helge Deller Mar 16, 2023

fbdev: intelfb: Fix potential divide by zero



Variable var->pixclock is controlled by user and can be assigned
to zero. Without proper check, divide by zero would occur in
intelfbhw_validate_mode and intelfbhw_mode_to_hw.

Error out if var->pixclock is zero.

Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>

parent 92e2a00f

drivers/video/fbdev/intelfb/intelfbdrv.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1222,6 +1222,9 @@ static int intelfb_check_var(struct fb_var_screeninfo *var,

		dinfo = GET_DINFO(info);

		if (!var->pixclock)
		return -EINVAL;

		/* update the pitch */
		if (intelfbhw_validate_mode(dinfo, var) != 0)
		return -EINVAL;