Commit d8c1fa4a authored by Julia Lawall's avatar Julia Lawall Committed by Stefan Richter
Browse files

ieee1394: video1394: Use memdup_user 



...when user data is immediately copied into the allocated region.

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> (changelog)
parent 3014420b

drivers/ieee1394/video1394.c

+3 −8
Original line number Diff line number Diff line
@@ -1045,14 +1045,9 @@ static long video1394_ioctl(struct file *file, 
			if (get_user(qv, &p->packet_sizes))

				return -EFAULT;



			psizes = kmalloc(buf_size, GFP_KERNEL);

			if (!psizes)

				return -ENOMEM;



			if (copy_from_user(psizes, qv, buf_size)) {

				kfree(psizes);

				return -EFAULT;

			}

			psizes = memdup_user(qv, buf_size);

			if (IS_ERR(psizes))

				return PTR_ERR(psizes);

		}



		spin_lock_irqsave(&d->lock,flags);