Commit dcdff74f authored Nov 11, 2020 by Qinglang Miao Committed by Mauro Carvalho Chehab Nov 17, 2020

media: solo6x10: fix missing snd_card_free in error handling case



Fix to goto snd_error in error handling case when fails
to do snd_ctl_add, as done elsewhere in this function.

Fixes: 28cae868 ("[media] solo6x10: move out of staging into drivers/media/pci.")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent 23ffa039

drivers/media/pci/solo6x10/solo6x10-g723.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -385,7 +385,7 @@ int solo_g723_init(struct solo_dev *solo_dev)

	ret = snd_ctl_add(card, snd_ctl_new1(&kctl, solo_dev));		ret = snd_ctl_add(card, snd_ctl_new1(&kctl, solo_dev));
	if (ret < 0)		if (ret < 0)
	return ret;		goto snd_error;

	ret = solo_snd_pcm_init(solo_dev);		ret = solo_snd_pcm_init(solo_dev);
	if (ret < 0)		if (ret < 0)