Commit dce15efe authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman
Browse files

staging: bcm: fix possible memory leak in bcm_char_ioctl() 

psFwInfo has been allocated in this function and should be
freed before leaving from the error handling cases.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/

)

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c14d01b8

drivers/staging/bcm/Bcmchar.c

+2 −0
Original line number Diff line number Diff line
@@ -820,6 +820,7 @@ static long bcm_char_ioctl(struct file *filp, UINT cmd, ULONG arg) 


		if (copy_from_user(psFwInfo, IoBuffer.InputBuffer, IoBuffer.InputLength)) {

			up(&Adapter->fw_download_sema);

			kfree(psFwInfo);

			return -EFAULT;

		}
@@ -829,6 +830,7 @@ static long bcm_char_ioctl(struct file *filp, UINT cmd, ULONG arg) 
			BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0, "Something else is wrong %lu\n",

					psFwInfo->u32FirmwareLength);

			up(&Adapter->fw_download_sema);

			kfree(psFwInfo);

			Status = -EINVAL;

			return Status;

		}