Commit dd549927 authored by Al Viro's avatar Al Viro
Browse files

ufs: switch to discard_new_inode() 



we don't want open-by-handle to pick an in-core inode that
has failed setup halfway through.

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 32955c54

fs/ufs/ialloc.c

+1 −2
Original line number Diff line number Diff line
@@ -343,8 +343,7 @@ struct inode *ufs_new_inode(struct inode *dir, umode_t mode) 
fail_remove_inode:

	mutex_unlock(&sbi->s_lock);

	clear_nlink(inode);

	unlock_new_inode(inode);

	iput(inode);

	discard_new_inode(inode);

	UFSD("EXIT (FAILED): err %d\n", err);

	return ERR_PTR(err);

failed:

fs/ufs/namei.c

+3 −6
Original line number Diff line number Diff line
@@ -43,8 +43,7 @@ static inline int ufs_add_nondir(struct dentry *dentry, struct inode *inode) 
		return 0;

	}

	inode_dec_link_count(inode);

	unlock_new_inode(inode);

	iput(inode);

	discard_new_inode(inode);

	return err;

}
@@ -142,8 +141,7 @@ static int ufs_symlink (struct inode * dir, struct dentry * dentry, 


out_fail:

	inode_dec_link_count(inode);

	unlock_new_inode(inode);

	iput(inode);

	discard_new_inode(inode);

	return err;

}
@@ -198,8 +196,7 @@ static int ufs_mkdir(struct inode * dir, struct dentry * dentry, umode_t mode) 
out_fail:

	inode_dec_link_count(inode);

	inode_dec_link_count(inode);

	unlock_new_inode(inode);

	iput (inode);

	discard_new_inode(inode);

out_dir:

	inode_dec_link_count(dir);

	return err;