Commit deefc58b authored by Daniel Starke's avatar Daniel Starke Committed by Greg Kroah-Hartman
Browse files

tty: n_gsm: fix wrong DLCI release order 



The current DLCI release order starts with the control channel followed by
the user channels. Reverse this order to keep the control channel open
until all user channels have been released.

Fixes: e1eaea46 ("tty: n_gsm line discipline")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDaniel Starke <daniel.starke@siemens.com>
Link: https://lore.kernel.org/r/20220414094225.4527-9-daniel.starke@siemens.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 535bf600

drivers/tty/n_gsm.c

+2 −2
Original line number Diff line number Diff line
@@ -2146,8 +2146,8 @@ static void gsm_cleanup_mux(struct gsm_mux *gsm, bool disc) 
	/* Finish outstanding timers, making sure they are done */

	del_timer_sync(&gsm->t2_timer);



	/* Free up any link layer users */

	for (i = 0; i < NUM_DLCI; i++)

	/* Free up any link layer users and finally the control channel */

	for (i = NUM_DLCI - 1; i >= 0; i--)

		if (gsm->dlci[i])

			gsm_dlci_release(gsm->dlci[i]);

	mutex_unlock(&gsm->mutex);