Commit df37c998 authored by Hans de Goede's avatar Hans de Goede Committed by Vinod Koul
Browse files

phy: ti: tusb1210: Add a delay between power-on and restoring the phy-parameters 



Now that we actually log errors on ulpi_write failures it becomes clear
that the ulpi_write() restoring the phy-parameters on power-on is failing
after a suspend/resume add a short delay after driving the cs line high
to fix this.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20220213130524.18748-9-hdegoede@redhat.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent cb7d21b4

drivers/phy/ti/phy-tusb1210.c

+5 −0
Original line number Diff line number Diff line
@@ -8,6 +8,7 @@ 
 */

#include <linux/module.h>

#include <linux/bitfield.h>

#include <linux/delay.h>

#include <linux/ulpi/driver.h>

#include <linux/ulpi/regs.h>

#include <linux/gpio/consumer.h>
@@ -18,6 +19,8 @@ 
#define TUSB1210_VENDOR_SPECIFIC2_ZHSDRV_MASK	GENMASK(5, 4)

#define TUSB1210_VENDOR_SPECIFIC2_DP_MASK	BIT(6)



#define TUSB1210_RESET_TIME_MS				30



struct tusb1210 {

	struct ulpi *ulpi;

	struct phy *phy;
@@ -60,6 +63,8 @@ static int tusb1210_power_on(struct phy *phy) 
	gpiod_set_value_cansleep(tusb->gpio_reset, 1);

	gpiod_set_value_cansleep(tusb->gpio_cs, 1);



	msleep(TUSB1210_RESET_TIME_MS);



	/* Restore the optional eye diagram optimization value */

	return tusb1210_ulpi_write(tusb, TUSB1210_VENDOR_SPECIFIC2,

				   tusb->vendor_specific2);