Commit e0bb4ab9 authored by Kuniyuki Iwashima's avatar Kuniyuki Iwashima Committed by David S. Miller
Browse files

tcp: Fix a data-race around sysctl_tcp_min_tso_segs. 



While reading sysctl_tcp_min_tso_segs, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.

Fixes: 95bd09eb ("tcp: TSO packets automatic sizing")
Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent db3815a2

net/ipv4/tcp_output.c

+1 −1
Original line number Diff line number Diff line
@@ -1995,7 +1995,7 @@ static u32 tcp_tso_segs(struct sock *sk, unsigned int mss_now) 


	min_tso = ca_ops->min_tso_segs ?

			ca_ops->min_tso_segs(sk) :

			sock_net(sk)->ipv4.sysctl_tcp_min_tso_segs;

			READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_min_tso_segs);



	tso_segs = tcp_tso_autosize(sk, mss_now, min_tso);

	return min_t(u32, tso_segs, sk->sk_gso_max_segs);