Commit e13c2ea2 authored by Jaehyun Chung's avatar Jaehyun Chung Committed by Alex Deucher
Browse files

drm/amd/display: Add check for validating unsupported ODM plus MPO case 



[Why]
We do not currently support ODM plus MPO on only one side of the
screen. This unsupported case causes validation calculations to
divide by zero due to invalid viewport values.

[How]
Add stopgap for the validation of ODM plus MPO on one side of
screen case.

Reviewed-by: default avatarDmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
Acked-by: default avatarAurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: default avatarJaehyun Chung <jaehyum.chung@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent f39b21c4

drivers/gpu/drm/amd/display/dc/core/dc_resource.c

+5 −0
Original line number Original line Diff line number Diff line
@@ -1051,6 +1051,11 @@ bool resource_build_scaling_params(struct pipe_ctx *pipe_ctx) 
	/* depends on scaling ratios and recout, does not calculate offset yet */

	/* depends on scaling ratios and recout, does not calculate offset yet */

	calculate_viewport_size(pipe_ctx);

	calculate_viewport_size(pipe_ctx);





	/* Stopgap for validation of ODM + MPO on one side of screen case */

	if (pipe_ctx->plane_res.scl_data.viewport.height < 1 ||

			pipe_ctx->plane_res.scl_data.viewport.width < 1)

		return false;



	/*

	/*

	 * LB calculations depend on vp size, h/v_active and scaling ratios

	 * LB calculations depend on vp size, h/v_active and scaling ratios

	 * Setting line buffer pixel depth to 24bpp yields banding

	 * Setting line buffer pixel depth to 24bpp yields banding