Commit e144f7ef authored by Xiangliang Yu's avatar Xiangliang Yu Committed by James Bottomley
Browse files

[SCSI] mvsas: update comments 



Remove obsolete comments and add new comments

Signed-off-by: default avatarXiangliang Yu <yuxiangl@marvell.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 84fbd0ce

drivers/scsi/mvsas/mv_64xx.c

+4 −13
Original line number Diff line number Diff line
@@ -33,7 +33,6 @@ static void mvs_64xx_detect_porttype(struct mvs_info *mvi, int i) 
	u32 reg;

	struct mvs_phy *phy = &mvi->phy[i];



	/* TODO check & save device type */

	reg = mr32(MVS_GBL_PORT_TYPE);

	phy->phy_type &= ~(PORT_TYPE_SAS | PORT_TYPE_SATA);

	if (reg & MODE_SAS_SATA & (1 << i))
@@ -63,7 +62,6 @@ static void __devinit mvs_64xx_phy_hacks(struct mvs_info *mvi) 
	mvs_phy_hacks(mvi);



	if (!(mvi->flags & MVF_FLAG_SOC)) {

		/* TEST - for phy decoding error, adjust voltage levels */

		for (i = 0; i < MVS_SOC_PORTS; i++) {

			mvs_write_port_vsr_addr(mvi, i, VSR_PHY_MODE8);

			mvs_write_port_vsr_data(mvi, i, 0x2F0);
@@ -375,13 +373,7 @@ static int __devinit mvs_64xx_init(struct mvs_info *mvi) 
		mvs_update_phyinfo(mvi, i, 1);

	}



	/* FIXME: update wide port bitmaps */



	/* little endian for open address and command table, etc. */

	/*

	 * it seems that ( from the spec ) turning on big-endian won't

	 * do us any good on big-endian machines, need further confirmation

	 */

	cctl = mr32(MVS_CTL);

	cctl |= CCTL_ENDIAN_CMD;

	cctl |= CCTL_ENDIAN_DATA;
@@ -394,8 +386,8 @@ static int __devinit mvs_64xx_init(struct mvs_info *mvi) 
	tmp |= PCS_CMD_RST;

	tmp &= ~PCS_SELF_CLEAR;

	mw32(MVS_PCS, tmp);

	/* interrupt coalescing may cause missing HW interrput in some case,

	 * and the max count is 0x1ff, while our max slot is 0x200,

	/*

	 * the max count is 0x1ff, while our max slot is 0x200,

	 * it will make count 0.

	 */

	tmp = 0;
@@ -632,7 +624,6 @@ static void mvs_64xx_phy_work_around(struct mvs_info *mvi, int i) 
{

	u32 tmp;

	struct mvs_phy *phy = &mvi->phy[i];

	/* workaround for HW phy decoding error on 1.5g disk drive */

	mvs_write_port_vsr_addr(mvi, i, VSR_PHY_MODE6);

	tmp = mvs_read_port_vsr_data(mvi, i);

	if (((phy->phy_status & PHY_NEG_SPP_PHYS_LINK_RATE_MASK) >>
@@ -765,8 +756,8 @@ static void mvs_64xx_tune_interrupt(struct mvs_info *mvi, u32 time) 
{

	void __iomem *regs = mvi->regs;

	u32 tmp = 0;

	/* interrupt coalescing may cause missing HW interrput in some case,

	 * and the max count is 0x1ff, while our max slot is 0x200,

	/*

	 * the max count is 0x1ff, while our max slot is 0x200,

	 * it will make count 0.

	 */

	if (time == 0) {

drivers/scsi/mvsas/mv_94xx.c

+6 −13
Original line number Diff line number Diff line
@@ -460,13 +460,7 @@ static int __devinit mvs_94xx_init(struct mvs_info *mvi) 
		mvs_update_phyinfo(mvi, i, 1);

	}



	/* FIXME: update wide port bitmaps */



	/* little endian for open address and command table, etc. */

	/*

	 * it seems that ( from the spec ) turning on big-endian won't

	 * do us any good on big-endian machines, need further confirmation

	 */

	cctl = mr32(MVS_CTL);

	cctl |= CCTL_ENDIAN_CMD;

	cctl &= ~CCTL_ENDIAN_OPEN;
@@ -478,8 +472,8 @@ static int __devinit mvs_94xx_init(struct mvs_info *mvi) 
	tmp |= PCS_CMD_RST;

	tmp &= ~PCS_SELF_CLEAR;

	mw32(MVS_PCS, tmp);

	/* interrupt coalescing may cause missing HW interrput in some case,

	 * and the max count is 0x1ff, while our max slot is 0x200,

	/*

	 * the max count is 0x1ff, while our max slot is 0x200,

	 * it will make count 0.

	 */

	tmp = 0;
@@ -488,6 +482,7 @@ static int __devinit mvs_94xx_init(struct mvs_info *mvi) 
	else

		mw32(MVS_INT_COAL, MVS_CHIP_SLOT_SZ | COAL_EN);



	/* default interrupt coalescing time is 128us */

	tmp = 0x10000 | interrupt_coalescing;

	mw32(MVS_INT_COAL_TMOUT, tmp);
@@ -745,7 +740,7 @@ static int mvs_94xx_oob_done(struct mvs_info *mvi, int i) 
{

	u32 phy_st;

	phy_st = mvs_read_phy_ctl(mvi, i);

	if (phy_st & PHY_READY_MASK)	/* phy ready */

	if (phy_st & PHY_READY_MASK)

		return 1;

	return 0;

}
@@ -770,7 +765,6 @@ static void mvs_94xx_get_att_identify_frame(struct mvs_info *mvi, int port_id, 
	int i;

	u32 id_frame[7];



	/* mvs_hexdump(28, (u8 *)id_frame, 0); */

	for (i = 0; i < 7; i++) {

		mvs_write_port_cfg_addr(mvi, port_id,

					CONFIG_ATT_ID_FRAME0 + i * 4);
@@ -778,7 +772,6 @@ static void mvs_94xx_get_att_identify_frame(struct mvs_info *mvi, int port_id, 
		mv_dprintk("94xx phy %d atta frame %d %x.\n",

			port_id + mvi->id * mvi->chip->n_phy, i, id_frame[i]);

	}

	/* mvs_hexdump(28, (u8 *)id_frame, 0); */

	memcpy(id, id_frame, 28);

}
@@ -962,8 +955,8 @@ static void mvs_94xx_tune_interrupt(struct mvs_info *mvi, u32 time) 
{

	void __iomem *regs = mvi->regs;

	u32 tmp = 0;

	/* interrupt coalescing may cause missing HW interrput in some case,

	 * and the max count is 0x1ff, while our max slot is 0x200,

	/*

	 * the max count is 0x1ff, while our max slot is 0x200,

	 * it will make count 0.

	 */

	if (time == 0) {

drivers/scsi/mvsas/mv_94xx.h

+12 −12
Original line number Diff line number Diff line
@@ -121,18 +121,18 @@ enum pci_cfg_registers { 


/*  SAS/SATA Vendor Specific Port Registers */

enum sas_sata_vsp_regs {

	VSR_PHY_STAT		= 0x00 * 4, /* Phy Status */

	VSR_PHY_MODE1		= 0x01 * 4, /* phy tx */

	VSR_PHY_MODE2		= 0x02 * 4, /* tx scc */

	VSR_PHY_MODE3		= 0x03 * 4, /* pll */

	VSR_PHY_MODE4		= 0x04 * 4, /* VCO */

	VSR_PHY_MODE5		= 0x05 * 4, /* Rx */

	VSR_PHY_MODE6		= 0x06 * 4, /* CDR */

	VSR_PHY_MODE7		= 0x07 * 4, /* Impedance */

	VSR_PHY_MODE8		= 0x08 * 4, /* Voltage */

	VSR_PHY_MODE9		= 0x09 * 4, /* Test */

	VSR_PHY_MODE10		= 0x0A * 4, /* Power */

	VSR_PHY_MODE11		= 0x0B * 4, /* Phy Mode */

	VSR_PHY_STAT		= 0x00 * 4, /* Phy Interrupt Status */

	VSR_PHY_MODE1		= 0x01 * 4, /* phy Interrupt Enable */

	VSR_PHY_MODE2		= 0x02 * 4, /* Phy Configuration */

	VSR_PHY_MODE3		= 0x03 * 4, /* Phy Status */

	VSR_PHY_MODE4		= 0x04 * 4, /* Phy Counter 0 */

	VSR_PHY_MODE5		= 0x05 * 4, /* Phy Counter 1 */

	VSR_PHY_MODE6		= 0x06 * 4, /* Event Counter Control */

	VSR_PHY_MODE7		= 0x07 * 4, /* Event Counter Select */

	VSR_PHY_MODE8		= 0x08 * 4, /* Event Counter 0 */

	VSR_PHY_MODE9		= 0x09 * 4, /* Event Counter 1 */

	VSR_PHY_MODE10		= 0x0A * 4, /* Event Counter 2 */

	VSR_PHY_MODE11		= 0x0B * 4, /* Event Counter 3 */

	VSR_PHY_ACT_LED		= 0x0C * 4, /* Activity LED control */



	VSR_PHY_FFE_CONTROL	= 0x10C,

drivers/scsi/mvsas/mv_chips.h

+0 −2
Original line number Diff line number Diff line
@@ -164,7 +164,6 @@ static inline void __devinit mvs_phy_hacks(struct mvs_info *mvi) 
{

	u32 tmp;



	/* workaround for SATA R-ERR, to ignore phy glitch */

	tmp = mvs_cr32(mvi, CMD_PHY_TIMER);

	tmp &= ~(1 << 9);

	tmp |= (1 << 10);
@@ -179,7 +178,6 @@ static inline void __devinit mvs_phy_hacks(struct mvs_info *mvi) 
	tmp |= 0x3fff;

	mvs_cw32(mvi, CMD_SAS_CTL0, tmp);



	/* workaround for WDTIMEOUT , set to 550 ms */

	mvs_cw32(mvi, CMD_WD_TIMER, 0x7a0000);



	/* not to halt for different port op during wideport link change */

drivers/scsi/mvsas/mv_defs.h

+1 −1
Original line number Diff line number Diff line
@@ -160,7 +160,7 @@ enum hw_register_bits { 
	TXQ_CMD_SSP		= 1,		/* SSP protocol */

	TXQ_CMD_SMP		= 2,		/* SMP protocol */

	TXQ_CMD_STP		= 3,		/* STP/SATA protocol */

	TXQ_CMD_SSP_FREE_LIST	= 4,		/* add to SSP targ free list */

	TXQ_CMD_SSP_FREE_LIST	= 4,		/* add to SSP target free list */

	TXQ_CMD_SLOT_RESET	= 7,		/* reset command slot */

	TXQ_MODE_I		= (1U << 28),	/* mode: 0=target,1=initiator */

	TXQ_MODE_TARGET 	= 0,