Commit e26ef3af authored by Jim Cromie's avatar Jim Cromie Committed by Greg Kroah-Hartman
Browse files

dyndbg: drop EXPORTed dynamic_debug_exec_queries 



This exported fn is unused, and will not be needed. Lets dump it.

The export was added to let drm control pr_debugs, as part of using
them to avoid drm_debug_enabled overheads.  But its better to just
implement the drm.debug bitmap interface, then its available for
everyone.

Fixes: a2d375ed ("dyndbg: refine export, rename to dynamic_debug_exec_queries()")
Fixes: 4c0d7782 ("dyndbg: export ddebug_exec_queries")
Acked-by: default avatarJason Baron <jbaron@akamai.com>
Acked-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarJim Cromie <jim.cromie@gmail.com>
Link: https://lore.kernel.org/r/20220904214134.408619-10-jim.cromie@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 683263a5

include/linux/dynamic_debug.h

+0 −9
Original line number Diff line number Diff line
@@ -55,9 +55,6 @@ struct _ddebug { 


#if defined(CONFIG_DYNAMIC_DEBUG_CORE)



/* exported for module authors to exercise >control */

int dynamic_debug_exec_queries(const char *query, const char *modname);



int ddebug_add_module(struct _ddebug *tab, unsigned int n,

				const char *modname);

extern int ddebug_remove_module(const char *mod_name);
@@ -221,12 +218,6 @@ static inline int ddebug_dyndbg_module_param_cb(char *param, char *val, 
				rowsize, groupsize, buf, len, ascii);	\

	} while (0)



static inline int dynamic_debug_exec_queries(const char *query, const char *modname)

{

	pr_warn("kernel not built with CONFIG_DYNAMIC_DEBUG_CORE\n");

	return 0;

}



#endif /* !CONFIG_DYNAMIC_DEBUG_CORE */



#endif

lib/dynamic_debug.c

+0 −29
Original line number Diff line number Diff line
@@ -558,35 +558,6 @@ static int ddebug_exec_queries(char *query, const char *modname) 
	return nfound;

}



/**

 * dynamic_debug_exec_queries - select and change dynamic-debug prints

 * @query: query-string described in admin-guide/dynamic-debug-howto

 * @modname: string containing module name, usually &module.mod_name

 *

 * This uses the >/proc/dynamic_debug/control reader, allowing module

 * authors to modify their dynamic-debug callsites. The modname is

 * canonically struct module.mod_name, but can also be null or a

 * module-wildcard, for example: "drm*".

 */

int dynamic_debug_exec_queries(const char *query, const char *modname)

{

	int rc;

	char *qry; /* writable copy of query */



	if (!query) {

		pr_err("non-null query/command string expected\n");

		return -EINVAL;

	}

	qry = kstrndup(query, PAGE_SIZE, GFP_KERNEL);

	if (!qry)

		return -ENOMEM;



	rc = ddebug_exec_queries(qry, modname);

	kfree(qry);

	return rc;

}

EXPORT_SYMBOL_GPL(dynamic_debug_exec_queries);



#define PREFIX_SIZE 64



static int remaining(int wrote)