Commit e42688ed authored Apr 16, 2020 by Dejin Zheng Committed by Wolfram Sang Apr 18, 2020

i2c: busses: remove duplicate dev_err()



it will print an error message by itself when platform_get_irq()
goes wrong. so don't need dev_err() in here again.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Suggested-by: Markus Elfring <Markus.Elfring@web.de>
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

parent e5175261

drivers/i2c/busses/i2c-altera.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -394,10 +394,8 @@ static int altr_i2c_probe(struct platform_device *pdev)
		return PTR_ERR(idev->base);

		irq = platform_get_irq(pdev, 0);
		if (irq < 0) {
		dev_err(&pdev->dev, "missing interrupt resource\n");
		if (irq < 0)
		return irq;
		}

		idev->i2c_clk = devm_clk_get(&pdev->dev, NULL);
		if (IS_ERR(idev->i2c_clk)) {

drivers/i2c/busses/i2c-axxia.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -746,10 +746,8 @@ static int axxia_i2c_probe(struct platform_device *pdev)
		return PTR_ERR(base);

		idev->irq = platform_get_irq(pdev, 0);
		if (idev->irq < 0) {
		dev_err(&pdev->dev, "missing interrupt resource\n");
		if (idev->irq < 0)
		return idev->irq;
		}

		idev->i2c_clk = devm_clk_get(&pdev->dev, "i2c");
		if (IS_ERR(idev->i2c_clk)) {

drivers/i2c/busses/i2c-bcm-kona.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -821,8 +821,7 @@ static int bcm_kona_i2c_probe(struct platform_device *pdev)
		/* Get the interrupt number */
		dev->irq = platform_get_irq(pdev, 0);
		if (dev->irq < 0) {
		dev_err(dev->device, "no irq resource\n");
		rc = -ENODEV;
		rc = dev->irq;
		goto probe_disable_clk;
		}

drivers/i2c/busses/i2c-cht-wc.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -314,10 +314,8 @@ static int cht_wc_i2c_adap_i2c_probe(struct platform_device *pdev)
		int ret, reg, irq;

		irq = platform_get_irq(pdev, 0);
		if (irq < 0) {
		dev_err(&pdev->dev, "Error missing irq resource\n");
		return -EINVAL;
		}
		if (irq < 0)
		return irq;

		adap = devm_kzalloc(&pdev->dev, sizeof(*adap), GFP_KERNEL);
		if (!adap)

drivers/i2c/busses/i2c-img-scb.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1342,10 +1342,8 @@ static int img_i2c_probe(struct platform_device *pdev)
		return PTR_ERR(i2c->base);

		irq = platform_get_irq(pdev, 0);
		if (irq < 0) {
		dev_err(&pdev->dev, "can't get irq number\n");
		if (irq < 0)
		return irq;
		}

		i2c->sys_clk = devm_clk_get(&pdev->dev, "sys");
		if (IS_ERR(i2c->sys_clk)) {