Commit e54638a8 authored by Maor Dickman's avatar Maor Dickman Committed by Saeed Mahameed
Browse files

net/mlx5e: Set geneve_tlv_option_0_exist when matching on geneve option 



The cited patch added support of matching on geneve option by setting
geneve_tlv_option_0_data mask and key but didn't set geneve_tlv_option_0_exist
bit which is required on some HWs when matching geneve_tlv_option_0_data parameter,
this may cause in some cases for packets to wrongly match on rules with different
geneve option.

Example of such case is packet with geneve_tlv_object class=789 and data=456
will wrongly match on rule with match geneve_tlv_object class=123 and data=456.

Fix it by setting geneve_tlv_option_0_exist bit when supported by the HW when matching
on geneve_tlv_option_0_data parameter.

Fixes: 9272e3df ("net/mlx5e: Geneve, Add support for encap/decap flows offload")
Signed-off-by: default avatarMaor Dickman <maord@nvidia.com>
Reviewed-by: default avatarRoi Dayan <roid@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 1e267ab8

drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_geneve.c

+5 −0
Original line number Diff line number Diff line
@@ -273,6 +273,11 @@ static int mlx5e_tc_tun_parse_geneve_options(struct mlx5e_priv *priv, 
		 geneve_tlv_option_0_data, be32_to_cpu(opt_data_key));

	MLX5_SET(fte_match_set_misc3, misc_3_c,

		 geneve_tlv_option_0_data, be32_to_cpu(opt_data_mask));

	if (MLX5_CAP_ESW_FLOWTABLE_FDB(priv->mdev,

				       ft_field_support.geneve_tlv_option_0_exist)) {

		MLX5_SET_TO_ONES(fte_match_set_misc, misc_c, geneve_tlv_option_0_exist);

		MLX5_SET_TO_ONES(fte_match_set_misc, misc_v, geneve_tlv_option_0_exist);

	}



	spec->match_criteria_enable |= MLX5_MATCH_MISC_PARAMETERS_3;