Commit e571f75b authored by Jonathan Bakker's avatar Jonathan Bakker Committed by Mauro Carvalho Chehab
Browse files

media: exynos4-is: Handle duplicate calls to vidioc_streamoff 



vidioc_streamoff can be called multiple times from userspace, but we
should only call media_pipeline_stop when we're actually setup.

This became more noticeable after commit 2a2599c6 ("[media] media:
entity: Catch unbalanced media_pipeline_stop calls") was merged as it
added a WARN for unbalanced calls to media_pipeline_stop.

Signed-off-by: default avatarJonathan Bakker <xc-racer2@live.ca>
Reviewed-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 4e3991c1

drivers/media/platform/exynos4-is/fimc-capture.c

+5 −2
Original line number Diff line number Diff line
@@ -1235,8 +1235,11 @@ static int fimc_cap_streamoff(struct file *file, void *priv, 
	if (ret < 0)

		return ret;



	if (vc->streaming) {

		media_pipeline_stop(&vc->ve.vdev.entity);

		vc->streaming = false;

	}



	return 0;

}