Commit e628f287 authored by Julian Wiedmann's avatar Julian Wiedmann Committed by Heiko Carstens
Browse files

s390/qdio: remove unneeded sanity check in qdio_do_sqbs() 



All callers of set_buf_states() are already making sure that 'count'
is not 0. So don't check it an additional time.

Note that our own code also doesn't _require_ the count to be sane
(ie. we can't overrun an array or similar). So worst case HW would
simply reject the SQBS operation and report an error.

Signed-off-by: default avatarJulian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: default avatarBenjamin Block <bblock@linux.ibm.com>
Signed-off-by: default avatarHeiko Carstens <hca@linux.ibm.com>
parent 568de506

drivers/s390/cio/qdio_main.c

+0 −2
Original line number Diff line number Diff line
@@ -170,8 +170,6 @@ static int qdio_do_sqbs(struct qdio_q *q, unsigned char state, int start, 
	int tmp_count = count, tmp_start = start;

	int nr = q->nr;



	if (!count)

		return 0;

	qperf_inc(q, sqbs);



	if (!q->is_input_q)