Commit e6487833 authored by Christoph Hellwig's avatar Christoph Hellwig
Browse files

nvme: move the Samsung X5 quirk entry to the core quirks 



This device shares the PCI ID with the Samsung 970 Evo Plus that
does not need or want the quirks.  Move the the quirk entry to the
core table based on the model number instead.

Fixes: bc360b0b ("nvme-pci: add quirks for Samsung X5 SSDs")
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarPankaj Raghav <p.raghav@samsung.com>
parent 23c9cd56

drivers/nvme/host/core.c

+14 −0
Original line number Diff line number Diff line
@@ -2546,6 +2546,20 @@ static const struct nvme_core_quirk_entry core_quirks[] = { 
		.vid = 0x1e0f,

		.mn = "KCD6XVUL6T40",

		.quirks = NVME_QUIRK_NO_APST,

	},

	{

		/*

		 * The external Samsung X5 SSD fails initialization without a

		 * delay before checking if it is ready and has a whole set of

		 * other problems.  To make this even more interesting, it

		 * shares the PCI ID with internal Samsung 970 Evo Plus that

		 * does not need or want these quirks.

		 */

		.vid = 0x144d,

		.mn = "Samsung Portable SSD X5",

		.quirks = NVME_QUIRK_DELAY_BEFORE_CHK_RDY |

			  NVME_QUIRK_NO_DEEPEST_PS |

			  NVME_QUIRK_IGNORE_DEV_SUBNQN,

	}

};

drivers/nvme/host/pci.c

+0 −4
Original line number Diff line number Diff line
@@ -3526,10 +3526,6 @@ static const struct pci_device_id nvme_id_table[] = { 
				NVME_QUIRK_128_BYTES_SQES |

				NVME_QUIRK_SHARED_TAGS |

				NVME_QUIRK_SKIP_CID_GEN },

	{ PCI_DEVICE(0x144d, 0xa808),   /* Samsung X5 */

		.driver_data =  NVME_QUIRK_DELAY_BEFORE_CHK_RDY|

				NVME_QUIRK_NO_DEEPEST_PS |

				NVME_QUIRK_IGNORE_DEV_SUBNQN, },

	{ PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },

	{ 0, }

};