Commit e68daf61 authored by Felix Fietkau's avatar Felix Fietkau Committed by David S. Miller
Browse files

net: ethernet: mtk_eth_soc: avoid creating duplicate offload entries 



Sometimes multiple CLS_REPLACE calls are issued for the same connection.
rhashtable_insert_fast does not check for these duplicates, so multiple
hardware flow entries can be created.
Fix this by checking for an existing entry early

Fixes: 502e84e2 ("net: ethernet: mtk_eth_soc: add flow offloading support")
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
Signed-off-by: default avatarIlya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 31339440

drivers/net/ethernet/mediatek/mtk_ppe_offload.c

+3 −0
Original line number Diff line number Diff line
@@ -186,6 +186,9 @@ mtk_flow_offload_replace(struct mtk_eth *eth, struct flow_cls_offload *f) 
	int hash;

	int i;



	if (rhashtable_lookup(&eth->flow_table, &f->cookie, mtk_flow_ht_params))

		return -EEXIST;



	if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_META)) {

		struct flow_match_meta match;