Unverified Commit e6ff3db9 authored by Peter Ujfalusi's avatar Peter Ujfalusi Committed by Mark Brown
Browse files

ASoC: SOF: ipc: Re-enable dumps after successful IPC tx 



The dumps are silenced after an IPC tx timeout by default.
The IPC timeout can indicate severe error (firmware crash) or in some cases
it is less devastating and the firmware remains operational, the timeout
was due to a scheduling spike or other anomaly.

In any case consequent IPC timeouts will not print dumps but if any IPC do
succeed than we should re-enable the dumps to print dumps the next time
a timeout might happen.

Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20211006110645.26679-13-peter.ujfalusi@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c05ec071

sound/soc/sof/ipc.c

+6 −0
Original line number Original line Diff line number Diff line
@@ -267,6 +267,12 @@ static int tx_wait_done(struct snd_sof_ipc *ipc, struct snd_sof_ipc_msg *msg, 
				memcpy(reply_data, msg->reply_data,

				memcpy(reply_data, msg->reply_data,

				       msg->reply_size);

				       msg->reply_size);

		}

		}



		/* re-enable dumps after successful IPC tx */

		if (sdev->ipc_dump_printed) {

			sdev->dbg_dump_printed = false;

			sdev->ipc_dump_printed = false;

		}

	}

	}





	return ret;

	return ret;