Commit e9685834 authored by Marcelo Aloisio da Silva's avatar Marcelo Aloisio da Silva Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: remove unconditional if statement 



Remove if condition that is always true. It is useless and
makes the code less readable.

Signed-off-by: default avatarMarcelo Aloisio da Silva <marcelo.as@aol.com>
Link: https://lore.kernel.org/r/20220215023926.GA52339@snoopy


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 66c123d8

drivers/staging/r8188eu/core/rtw_ap.c

+62 −62
Original line number Diff line number Diff line
@@ -55,17 +55,15 @@ static void update_BCNTIM(struct adapter *padapter) 
	struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;

	struct wlan_bssid_ex *pnetwork_mlmeext = &pmlmeinfo->network;

	unsigned char *pie = pnetwork_mlmeext->IEs;



	/* update TIM IE */

	if (true) {

	u8 *p, *dst_ie, *premainder_ie = NULL;

	u8 *pbackup_remainder_ie = NULL;

	__le16 tim_bitmap_le;

	uint offset, tmp_len, tim_ielen, tim_ie_offset, remainder_ielen;



		tim_bitmap_le = cpu_to_le16(pstapriv->tim_bitmap);

	/* update TIM IE */



		p = rtw_get_ie(pie + _FIXED_IE_LENGTH_, _TIM_IE_, &tim_ielen, pnetwork_mlmeext->IELength - _FIXED_IE_LENGTH_);

	p = rtw_get_ie(pie + _FIXED_IE_LENGTH_, _TIM_IE_, &tim_ielen,

		       pnetwork_mlmeext->IELength - _FIXED_IE_LENGTH_);

	if (p && tim_ielen > 0) {

		tim_ielen += 2;

		premainder_ie = p + tim_ielen;
@@ -81,7 +79,8 @@ static void update_BCNTIM(struct adapter *padapter) 
		offset += pnetwork_mlmeext->Ssid.SsidLength + 2;



		/*  get supported rates len */

			p = rtw_get_ie(pie + _BEACON_IE_OFFSET_, _SUPPORTEDRATES_IE_, &tmp_len, (pnetwork_mlmeext->IELength - _BEACON_IE_OFFSET_));

		p = rtw_get_ie(pie + _BEACON_IE_OFFSET_, _SUPPORTEDRATES_IE_,

			       &tmp_len, (pnetwork_mlmeext->IELength - _BEACON_IE_OFFSET_));

		if (p)

			offset += tmp_len + 2;
@@ -118,6 +117,8 @@ static void update_BCNTIM(struct adapter *padapter) 
	else

		*dst_ie++ = 0;



	tim_bitmap_le = cpu_to_le16(pstapriv->tim_bitmap);



	if (tim_ielen == 4) {

		*dst_ie++ = *(u8 *)&tim_bitmap_le;

	} else if (tim_ielen == 5) {
@@ -133,7 +134,6 @@ static void update_BCNTIM(struct adapter *padapter) 
	}

	offset =  (uint)(dst_ie - pie);

	pnetwork_mlmeext->IELength = offset + remainder_ielen;

	}



	set_tx_beacon_cmd(padapter);

}