Commit e99e802f authored by Hans Holmberg's avatar Hans Holmberg Committed by Jens Axboe
Browse files

lightnvm: pblk: remove unused parameters in pblk_up_rq 



The parameters nr_ppas and ppa_list are not used, so remove them.

Signed-off-by: default avatarHans Holmberg <hans.holmberg@cnexlabs.com>
Signed-off-by: default avatarMatias Bjørling <mb@lightnvm.io>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 53d82db6

drivers/lightnvm/pblk-core.c

+1 −2
Original line number Diff line number Diff line
@@ -1929,8 +1929,7 @@ void pblk_up_page(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas) 
	up(&rlun->wr_sem);

}



void pblk_up_rq(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas,

		unsigned long *lun_bitmap)

void pblk_up_rq(struct pblk *pblk, unsigned long *lun_bitmap)

{

	struct nvm_tgt_dev *dev = pblk->dev;

	struct nvm_geo *geo = &dev->geo;

drivers/lightnvm/pblk-write.c

+2 −3
Original line number Diff line number Diff line
@@ -81,8 +81,7 @@ static void pblk_complete_write(struct pblk *pblk, struct nvm_rq *rqd, 
#ifdef CONFIG_NVM_PBLK_DEBUG

	atomic_long_sub(c_ctx->nr_valid, &pblk->inflight_writes);

#endif



	pblk_up_rq(pblk, rqd->ppa_list, rqd->nr_ppas, c_ctx->lun_bitmap);

	pblk_up_rq(pblk, c_ctx->lun_bitmap);



	pos = pblk_rb_sync_init(&pblk->rwb, &flags);

	if (pos == c_ctx->sentry) {
@@ -215,7 +214,7 @@ static void pblk_submit_rec(struct work_struct *work) 
	pblk_map_remaining(pblk, ppa_list);

	pblk_queue_resubmit(pblk, c_ctx);



	pblk_up_rq(pblk, rqd->ppa_list, rqd->nr_ppas, c_ctx->lun_bitmap);

	pblk_up_rq(pblk, c_ctx->lun_bitmap);

	if (c_ctx->nr_padded)

		pblk_bio_free_pages(pblk, rqd->bio, c_ctx->nr_valid,

							c_ctx->nr_padded);

drivers/lightnvm/pblk.h

+1 −2
Original line number Diff line number Diff line
@@ -827,8 +827,7 @@ void pblk_up_page(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas); 
void pblk_down_rq(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas,

		  unsigned long *lun_bitmap);

void pblk_down_page(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas);

void pblk_up_rq(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas,

		unsigned long *lun_bitmap);

void pblk_up_rq(struct pblk *pblk, unsigned long *lun_bitmap);

int pblk_bio_add_pages(struct pblk *pblk, struct bio *bio, gfp_t flags,

		       int nr_pages);

void pblk_bio_free_pages(struct pblk *pblk, struct bio *bio, int off,