Commit ea097de7 authored by Jérôme Pouiller's avatar Jérôme Pouiller Committed by Greg Kroah-Hartman
Browse files

staging: wfx: fix endianness of fields media_delay and tx_queue_delay 



The struct hif_cnf_tx contains only little endian values. Thus, it is
necessary to fix byte ordering before to use them. Especially, sparse
detected wrong access to fields media_delay and tx_queue_delay.

Signed-off-by: default avatarJérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200512150414.267198-7-Jerome.Pouiller@silabs.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a823d6ec

drivers/staging/wfx/data_tx.c

+2 −1
Original line number Diff line number Diff line
@@ -562,7 +562,8 @@ void wfx_tx_confirm_cb(struct wfx_vif *wvif, const struct hif_cnf_tx *arg) 


	if (!arg->status) {

		tx_info->status.tx_time =

		arg->media_delay - arg->tx_queue_delay;

			le32_to_cpu(arg->media_delay) -

			le32_to_cpu(arg->tx_queue_delay);

		if (tx_info->flags & IEEE80211_TX_CTL_NO_ACK)

			tx_info->flags |= IEEE80211_TX_STAT_NOACK_TRANSMITTED;

		else

drivers/staging/wfx/traces.h

+2 −2
Original line number Diff line number Diff line
@@ -387,8 +387,8 @@ TRACE_EVENT(tx_stats, 
		int i;



		__entry->pkt_id = tx_cnf->packet_id;

		__entry->delay_media = tx_cnf->media_delay;

		__entry->delay_queue = tx_cnf->tx_queue_delay;

		__entry->delay_media = le32_to_cpu(tx_cnf->media_delay);

		__entry->delay_queue = le32_to_cpu(tx_cnf->tx_queue_delay);

		__entry->delay_fw = delay;

		__entry->ack_failures = tx_cnf->ack_failures;

		if (!tx_cnf->status || __entry->ack_failures)