Commit ece43fad authored by Cheng Xu's avatar Cheng Xu Committed by Leon Romanovsky
Browse files

RDMA/erdma: Extend access right field of FRMR and REG MR to support atomic 



To support atomic operations, IB_ACCESS_REMOTE_ATOMIC right should be
passed to hardware for permission check. Since "access mode" field in FRMR
SQE and RegMr command is never used by hw, we remove the "access mode"
field, so that we can then have enough space to extend access fields.

Signed-off-by: default avatarCheng Xu <chengyou@linux.alibaba.com>
Link: https://lore.kernel.org/r/20221107021845.44598-2-chengyou@linux.alibaba.com


Signed-off-by: default avatarLeon Romanovsky <leon@kernel.org>
parent 4eace75e

drivers/infiniband/hw/erdma/erdma_hw.h

+2 −4
Original line number Diff line number Diff line
@@ -224,8 +224,7 @@ struct erdma_cmdq_create_cq_req { 
/* regmr cfg1 */

#define ERDMA_CMD_REGMR_PD_MASK GENMASK(31, 12)

#define ERDMA_CMD_REGMR_TYPE_MASK GENMASK(7, 6)

#define ERDMA_CMD_REGMR_RIGHT_MASK GENMASK(5, 2)

#define ERDMA_CMD_REGMR_ACC_MODE_MASK GENMASK(1, 0)

#define ERDMA_CMD_REGMR_RIGHT_MASK GENMASK(5, 1)



/* regmr cfg2 */

#define ERDMA_CMD_REGMR_PAGESIZE_MASK GENMASK(31, 27)
@@ -370,8 +369,7 @@ struct erdma_rqe { 
#define ERDMA_SQE_HDR_WQEBB_INDEX_MASK GENMASK_ULL(15, 0)



/* REG MR attrs */

#define ERDMA_SQE_MR_MODE_MASK GENMASK(1, 0)

#define ERDMA_SQE_MR_ACCESS_MASK GENMASK(5, 2)

#define ERDMA_SQE_MR_ACCESS_MASK GENMASK(5, 1)

#define ERDMA_SQE_MR_MTT_TYPE_MASK GENMASK(7, 6)

#define ERDMA_SQE_MR_MTT_CNT_MASK GENMASK(31, 12)

drivers/infiniband/hw/erdma/erdma_qp.c

+1 −2
Original line number Diff line number Diff line
@@ -397,8 +397,7 @@ static int erdma_push_one_sqe(struct erdma_qp *qp, u16 *pi, 
		regmr_sge->addr = cpu_to_le64(mr->ibmr.iova);

		regmr_sge->length = cpu_to_le32(mr->ibmr.length);

		regmr_sge->stag = cpu_to_le32(reg_wr(send_wr)->key);

		attrs = FIELD_PREP(ERDMA_SQE_MR_MODE_MASK, 0) |

			FIELD_PREP(ERDMA_SQE_MR_ACCESS_MASK, mr->access) |

		attrs = FIELD_PREP(ERDMA_SQE_MR_ACCESS_MASK, mr->access) |

			FIELD_PREP(ERDMA_SQE_MR_MTT_CNT_MASK,

				   mr->mem.mtt_nents);

drivers/infiniband/hw/erdma/erdma_verbs.c

+1 −2
Original line number Diff line number Diff line
@@ -118,8 +118,7 @@ static int regmr_cmd(struct erdma_dev *dev, struct erdma_mr *mr) 
		   FIELD_PREP(ERDMA_CMD_MR_MPT_IDX_MASK, mr->ibmr.lkey >> 8);

	req.cfg1 = FIELD_PREP(ERDMA_CMD_REGMR_PD_MASK, pd->pdn) |

		   FIELD_PREP(ERDMA_CMD_REGMR_TYPE_MASK, mr->type) |

		   FIELD_PREP(ERDMA_CMD_REGMR_RIGHT_MASK, mr->access) |

		   FIELD_PREP(ERDMA_CMD_REGMR_ACC_MODE_MASK, 0);

		   FIELD_PREP(ERDMA_CMD_REGMR_RIGHT_MASK, mr->access);

	req.cfg2 = FIELD_PREP(ERDMA_CMD_REGMR_PAGESIZE_MASK,

			      ilog2(mr->mem.page_size)) |

		   FIELD_PREP(ERDMA_CMD_REGMR_MTT_TYPE_MASK, mr->mem.mtt_type) |

drivers/infiniband/hw/erdma/erdma_verbs.h

+7 −5
Original line number Diff line number Diff line
@@ -71,16 +71,18 @@ struct erdma_pd { 
#define ERDMA_MR_INLINE_MTT 0

#define ERDMA_MR_INDIRECT_MTT 1



#define ERDMA_MR_ACC_LR BIT(0)

#define ERDMA_MR_ACC_LW BIT(1)

#define ERDMA_MR_ACC_RR BIT(2)

#define ERDMA_MR_ACC_RW BIT(3)

#define ERDMA_MR_ACC_RA BIT(0)

#define ERDMA_MR_ACC_LR BIT(1)

#define ERDMA_MR_ACC_LW BIT(2)

#define ERDMA_MR_ACC_RR BIT(3)

#define ERDMA_MR_ACC_RW BIT(4)



static inline u8 to_erdma_access_flags(int access)

{

	return (access & IB_ACCESS_REMOTE_READ ? ERDMA_MR_ACC_RR : 0) |

	       (access & IB_ACCESS_LOCAL_WRITE ? ERDMA_MR_ACC_LW : 0) |

	       (access & IB_ACCESS_REMOTE_WRITE ? ERDMA_MR_ACC_RW : 0);

	       (access & IB_ACCESS_REMOTE_WRITE ? ERDMA_MR_ACC_RW : 0) |

	       (access & IB_ACCESS_REMOTE_ATOMIC ? ERDMA_MR_ACC_RA : 0);

}



struct erdma_mem {