Commit ed21d6d7 authored by Remi Bernon's avatar Remi Bernon Committed by Arnaldo Carvalho de Melo
Browse files

perf tests: Add test for PE binary format support 



This adds a precompiled file in PE binary format, with split debug file,
and tries to read its build_id and .gnu_debuglink sections, as well as
looking up the main symbol from the debug file. This should succeed if
libbfd is supported.

Committer testing:

  $ perf test "PE file support"
  68: PE file support           : Ok
  $

Signed-off-by: default avatarRemi Bernon <rbernon@codeweavers.com>
Tested-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jacek Caban <jacek@codeweavers.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20200821165238.1340315-3-rbernon@codeweavers.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent eac9a434

tools/perf/Makefile.perf

+1 −0
Original line number Diff line number Diff line
@@ -961,6 +961,7 @@ install-tests: all install-gtk 
	$(call QUIET_INSTALL, tests) \

		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \

		$(INSTALL) tests/attr.py '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \

		$(INSTALL) tests/pe-file.exe* '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests'; \

		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'; \

		$(INSTALL) tests/attr/* '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/attr'; \

		$(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/tests/shell'; \

tools/perf/tests/Build

+1 −0
Original line number Diff line number Diff line
@@ -60,6 +60,7 @@ perf-y += api-io.o 
perf-y += demangle-java-test.o

perf-y += pfm.o

perf-y += parse-metric.o

perf-y += pe-file-parsing.o



$(OUTPUT)tests/llvm-src-base.c: tests/bpf-script-example.c tests/Build

	$(call rule_mkdir)

tools/perf/tests/builtin-test.c

+4 −0
Original line number Diff line number Diff line
@@ -341,6 +341,10 @@ static struct test generic_tests[] = { 
		.desc = "Parse and process metrics",

		.func = test__parse_metric,

	},

	{

		.desc = "PE file support",

		.func = test__pe_file_parsing,

	},

	{

		.func = NULL,

	},

tools/perf/tests/pe-file-parsing.c

0 → 100644
+98 −0
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

#include <stdbool.h>

#include <inttypes.h>

#include <stdlib.h>

#include <string.h>

#include <linux/bitops.h>

#include <linux/kernel.h>

#include <linux/types.h>

#include <sys/types.h>

#include <sys/stat.h>

#include <unistd.h>

#include <subcmd/exec-cmd.h>



#include "debug.h"

#include "util/build-id.h"

#include "util/symbol.h"

#include "util/dso.h"



#include "tests.h"



#ifdef HAVE_LIBBFD_SUPPORT



static int run_dir(const char *d)

{

	char filename[PATH_MAX];

	char debugfile[PATH_MAX];

	char build_id[BUILD_ID_SIZE];

	char debuglink[PATH_MAX];

	char expect_build_id[] = {

		0x5a, 0x0f, 0xd8, 0x82, 0xb5, 0x30, 0x84, 0x22,

		0x4b, 0xa4, 0x7b, 0x62, 0x4c, 0x55, 0xa4, 0x69,

	};

	char expect_debuglink[PATH_MAX] = "pe-file.exe.debug";

	struct dso *dso;

	struct symbol *sym;

	int ret;



	scnprintf(filename, PATH_MAX, "%s/pe-file.exe", d);

	ret = filename__read_build_id(filename, build_id, BUILD_ID_SIZE);

	TEST_ASSERT_VAL("Failed to read build_id",

			ret == sizeof(expect_build_id));

	TEST_ASSERT_VAL("Wrong build_id", !memcmp(build_id, expect_build_id,

						  sizeof(expect_build_id)));



	ret = filename__read_debuglink(filename, debuglink, PATH_MAX);

	TEST_ASSERT_VAL("Failed to read debuglink", ret == 0);

	TEST_ASSERT_VAL("Wrong debuglink",

			!strcmp(debuglink, expect_debuglink));



	scnprintf(debugfile, PATH_MAX, "%s/%s", d, debuglink);

	ret = filename__read_build_id(debugfile, build_id, BUILD_ID_SIZE);

	TEST_ASSERT_VAL("Failed to read debug file build_id",

			ret == sizeof(expect_build_id));

	TEST_ASSERT_VAL("Wrong build_id", !memcmp(build_id, expect_build_id,

						  sizeof(expect_build_id)));



	dso = dso__new(filename);

	TEST_ASSERT_VAL("Failed to get dso", dso);



	ret = dso__load_bfd_symbols(dso, debugfile);

	TEST_ASSERT_VAL("Failed to load symbols", ret == 0);



	dso__sort_by_name(dso);

	sym = dso__find_symbol_by_name(dso, "main");

	TEST_ASSERT_VAL("Failed to find main", sym);

	dso__delete(dso);



	return TEST_OK;

}



int test__pe_file_parsing(struct test *test __maybe_unused,

			  int subtest __maybe_unused)

{

	struct stat st;

	char path_dir[PATH_MAX];



	/* First try development tree tests. */

	if (!lstat("./tests", &st))

		return run_dir("./tests");



	/* Then installed path. */

	snprintf(path_dir, PATH_MAX, "%s/tests", get_argv_exec_path());



	if (!lstat(path_dir, &st))

		return run_dir(path_dir);



	return TEST_SKIP;

}



#else



int test__pe_file_parsing(struct test *test __maybe_unused,

			  int subtest __maybe_unused)

{

	return TEST_SKIP;

}



#endif

tools/perf/tests/pe-file.c

0 → 100644
+14 −0
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0



// pe-file.exe and pe-file.exe.debug built with;

// x86_64-w64-mingw32-gcc -o pe-file.exe pe-file.c

//   -Wl,--file-alignment,4096 -Wl,--build-id

// x86_64-w64-mingw32-objcopy --only-keep-debug

//   --compress-debug-sections pe-file.exe pe-file.exe.debug

// x86_64-w64-mingw32-objcopy --strip-debug

//   --add-gnu-debuglink=pe-file.exe.debug pe-file.exe



int main(int argc, char const *argv[])

{

	return 0;

}