Commit ed50be81 authored by Chunfeng Yun's avatar Chunfeng Yun Committed by Greg Kroah-Hartman
Browse files

usb: mtu3: unlock @mtu->lock just before giving back request 



No need unlock @mtu->lock when unmap request, unlock it just before
giving back request, due to we do not lock this spinlock when map
the request.

Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: default avatarChunfeng Yun <chunfeng.yun@mediatek.com>
Link: https://lore.kernel.org/r/20230417025203.18097-4-chunfeng.yun@mediatek.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d28f4091

drivers/usb/mtu3/mtu3_gadget.c

+1 −1
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ __acquires(mep->mtu->lock) 
		req->status = status;



	trace_mtu3_req_complete(mreq);

	spin_unlock(&mtu->lock);



	/* ep0 makes use of PIO, needn't unmap it */

	if (mep->epnum)
@@ -32,6 +31,7 @@ __acquires(mep->mtu->lock) 
	dev_dbg(mtu->dev, "%s complete req: %p, sts %d, %d/%d\n",

		mep->name, req, req->status, req->actual, req->length);



	spin_unlock(&mtu->lock);

	usb_gadget_giveback_request(&mep->ep, req);

	spin_lock(&mtu->lock);

}