Unverified Commit ef8a29ba authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: SOF: ipc4-topology: restore gateway config length 



The initial code had a logic flaw where the gateway config length kept
increasing after each playback/capture trigger, with the DMA config
TLV being added at every call of sof_ipc4_prepare_copier_module()

This didn't cause any issues with regular playback/capture, but this
was flagged as an error by firmware in the case of multiple amplifiers
on different links.

Fixes: a0659f81 ("ASoC: SOF: ipc4-topology: add DMA config TLV to IPC data")
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20230807210959.506849-5-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent defc0c63

sound/soc/sof/ipc4-topology.c

+6 −0
Original line number Diff line number Diff line
@@ -1746,6 +1746,12 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget, 
	/* update pipeline memory usage */

	sof_ipc4_update_resource_usage(sdev, swidget, &copier_data->base_config);



	/*

	 * Restore gateway config length now that IPC payload is prepared. This avoids

	 * counting the DMA CONFIG TLV multiple times

	 */

	copier_data->gtw_cfg.config_length = gtw_cfg_config_length / 4;



	return 0;

}