Commit f032e2cd authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

staging: greybus: camera: Switch to memdup_user_nul() 



Use memdup_user_nul() helper instead of open-coding to
simplify the code.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Reviewed-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20210401103645.1558813-1-yangyingliang@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0778f04b

drivers/staging/greybus/camera.c

+3 −10
Original line number Diff line number Diff line
@@ -1120,16 +1120,9 @@ static ssize_t gb_camera_debugfs_write(struct file *file, 
	if (len > 1024)

		return -EINVAL;



	kbuf = kmalloc(len + 1, GFP_KERNEL);

	if (!kbuf)

		return -ENOMEM;



	if (copy_from_user(kbuf, buf, len)) {

		ret = -EFAULT;

		goto done;

	}



	kbuf[len] = '\0';

	kbuf = memdup_user_nul(buf, len);

	if (IS_ERR(kbuf))

		return PTR_ERR(kbuf);



	ret = op->execute(gcam, kbuf, len);