Commit f0f7c502 authored by Allison Henderson's avatar Allison Henderson
Browse files

xfs: Separate xfs_attr_node_addname and xfs_attr_node_addname_clear_incomplete 



This patch separate xfs_attr_node_addname into two functions.  This will
help to make it easier to hoist parts of xfs_attr_node_addname that need
state management

Signed-off-by: default avatarAllison Henderson <allison.henderson@oracle.com>
Reviewed-by: default avatarBrian Foster <bfoster@redhat.com>
Reviewed-by: default avatarChandan Babu R <chandanrlinux@gmail.com>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
parent 6286514b

fs/xfs/libxfs/xfs_attr.c

+23 −0
Original line number Diff line number Diff line
@@ -54,6 +54,7 @@ STATIC int xfs_attr_leaf_hasname(struct xfs_da_args *args, struct xfs_buf **bp); 
STATIC int xfs_attr_node_get(xfs_da_args_t *args);

STATIC int xfs_attr_node_addname(xfs_da_args_t *args);

STATIC int xfs_attr_node_removename(xfs_da_args_t *args);

STATIC int xfs_attr_node_addname_clear_incomplete(struct xfs_da_args *args);

STATIC int xfs_attr_node_hasname(xfs_da_args_t *args,

				 struct xfs_da_state **state);

STATIC int xfs_attr_fillstate(xfs_da_state_t *state);
@@ -1073,6 +1074,28 @@ xfs_attr_node_addname( 
			return error;

	}



	error = xfs_attr_node_addname_clear_incomplete(args);

	if (error)

		goto out;

	retval = 0;

out:

	if (state)

		xfs_da_state_free(state);

	if (error)

		return error;

	return retval;

}





STATIC int

xfs_attr_node_addname_clear_incomplete(

	struct xfs_da_args		*args)

{

	struct xfs_da_state		*state = NULL;

	struct xfs_da_state_blk		*blk;

	int				retval = 0;

	int				error = 0;



	/*

	 * Re-find the "old" attribute entry after any split ops. The INCOMPLETE

	 * flag means that we will find the "old" attr, not the "new" one.