Commit f1995d5e authored by Dinghao Liu's avatar Dinghao Liu Committed by Mauro Carvalho Chehab
Browse files

media: sun8i-di: Fix runtime PM imbalance in deinterlace_start_streaming 



pm_runtime_get_sync() will increase the runtime PM counter
even it returns an error. Thus a pairing decrement is needed
to prevent refcount leak. Fix this by replacing this API with
pm_runtime_resume_and_get(), which will not change the runtime
PM counter on error.

Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 69306a94

drivers/media/platform/sunxi/sun8i-di/sun8i-di.c

+1 −1
Original line number Diff line number Diff line
@@ -589,7 +589,7 @@ static int deinterlace_start_streaming(struct vb2_queue *vq, unsigned int count) 
	int ret;



	if (V4L2_TYPE_IS_OUTPUT(vq->type)) {

		ret = pm_runtime_get_sync(dev);

		ret = pm_runtime_resume_and_get(dev);

		if (ret < 0) {

			dev_err(dev, "Failed to enable module\n");